fix(editor): Replace v-html with custom directive to sanitize html #10804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
tomi
reviewed
Sep 13, 2024
...system/src/components/AskAssistantChat/__tests__/__snapshots__/AskAssistantChat.spec.ts.snap
Outdated
Show resolved
Hide resolved
tomi
reviewed
Sep 13, 2024
This reverts commit 4e4c4fd.
# Conflicts: # packages/design-system/src/components/AskAssistantChat/AskAssistantChat.vue # pnpm-lock.yaml
tomi
reviewed
Sep 17, 2024
packages/editor-ui/src/components/banners/__tests__/__snapshots__/V1Banner.spec.ts.snap
Show resolved
Hide resolved
tomi
previously approved these changes
Sep 17, 2024
|
|
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
replace-v-html
|
| Run status |
|
| Run duration | 04m 44s |
| Commit |
|
| Committer | Tomi Turtiainen |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
430
|
| View all changes introduced in this branch ↗︎ | |
tomi
previously approved these changes
Sep 17, 2024
|
|
# Conflicts: # packages/design-system/src/directives/index.ts
# Conflicts: # pnpm-lock.yaml
tomi
approved these changes
Sep 18, 2024
|
✅ All Cypress E2E specs passed |
Merged
|
Got released with |
riascho
pushed a commit
that referenced
this pull request
Sep 23, 2024
…10804) Co-authored-by: Tomi Turtiainen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace
v-htmlwith custom directive to sanitize htmlReview / Merge checklist
release/backport