fix(Chat Trigger Node): Fix auth in "Embedded Chat" mode #10734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanpaul
approved these changes
Sep 9, 2024
|
✅ All Cypress E2E specs passed |
OlegIvaniv
deleted the
ai-335-basic-auth-on-chat-trigger-is-not-working
branch
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
master
|
| Run status |
|
| Run duration | 05m 24s |
| Commit |
|
| Committer | oleg |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
425
|
| View all changes introduced in this branch ↗︎ | |
MiloradFilipovic
added a commit
that referenced
this pull request
Sep 10, 2024
* master: feat(benchmark): New options for n8n benchmark (#10741) fix(Chat Trigger Node): Fix auth in "Embedded Chat" mode (#10734) fix(Webflow Node): Update scopes to include forms (#10554) test(editor): Add unit tests for `sanitizeHtml` (#10737) fix(editor): Fix xss issues in toast usages (#10733) fix(OpenAI Chat Model Node): Prevent filtering of fine-tuned models in model selector (#10662) feat: Filter parameter: Improve loose type validation for booleans (#10702) test: Add scaling n8n setup (multi-main) (#10644) refactor(editor): Migrate NodeWebhooks to Composition API (no-changelog) (#10710) fix(editor): Fix broken executions view (no-changelog) (#10714) fix(editor): Don't render pinned icon for disabled nodes (#10712)
Merged
|
Got released with |
riascho
pushed a commit
that referenced
this pull request
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue with Chat Trigger Node where the request wouldn't be adequately validated in "Embedded Chat" mode due to validation try/catch nested in
nodeMode === 'hostedChat'guardReview / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)