fix: Fix the issue in Trigger Nodes where poll time was not loaded #10695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Elias Meire <[email protected]>
ShireenMissi
force-pushed
the
node-1686-gmail-trigger-node-cant-activate-the-workflow
branch
from
7285924 to
452a7a0
Compare
ShireenMissi
added
the
release/backport
OlegIvaniv
approved these changes
Sep 5, 2024
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
node-1686-gmail-trigger-node-cant-activate-the-workflow
|
| Run status |
|
| Run duration | 04m 47s |
| Commit |
|
| Committer | Oleg Ivaniv |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
424
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
ShireenMissi
deleted the
node-1686-gmail-trigger-node-cant-activate-the-workflow
branch
tomi
pushed a commit
that referenced
this pull request
Sep 6, 2024
…10695) Co-authored-by: Elias Meire <[email protected]> Co-authored-by: Oleg Ivaniv <[email protected]>
Merged
|
Got released with |
Merged
riascho
pushed a commit
that referenced
this pull request
Sep 23, 2024
…10695) Co-authored-by: Elias Meire <[email protected]> Co-authored-by: Oleg Ivaniv <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR Fixes the issue in loading the poll time for Trigger nodes introduced in #10641
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-1686/gmail-trigger-node-cant-activate-the-workflow
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)