Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(Schedule Trigger Node): Add tests and extract trigger test helper (no-changelog) #10625

Merged
merged 3 commits into from
Sep 27, 2024

Conversation

elsmr
Copy link
Member

@elsmr elsmr commented Aug 30, 2024

Summary

  • Add tests to Schedule Trigger node
  • Extract helper to test trigger nodes

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-1709/improve-trigger-nodes-testing

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Aug 30, 2024
@elsmr elsmr marked this pull request as ready for review September 27, 2024 14:54
@elsmr elsmr changed the title refactor: Extract util to test trigger nodes more easily (WIP) test: Add tests to Schedule Trigger node Sep 27, 2024
@elsmr elsmr changed the title test: Add tests to Schedule Trigger node testO: Add tests to Schedule Trigger node Sep 27, 2024
@elsmr elsmr changed the title testO: Add tests to Schedule Trigger node test(Schedule Node): Add tests to Schedule Trigger node Sep 27, 2024
@elsmr elsmr changed the title test(Schedule Node): Add tests to Schedule Trigger node test(Schedule Trigger Node): Add tests and extract trigger test helper Sep 27, 2024
@ShireenMissi ShireenMissi changed the title test(Schedule Trigger Node): Add tests and extract trigger test helper test(Schedule Trigger Node): Add tests and extract trigger test helper (no-changelog) Sep 27, 2024
Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Copy link

cypress bot commented Sep 27, 2024

n8n    Run #7083

Run Properties:  status check passed Passed #7083  •  git commit 0ff0f1aa11: 🌳 master 🖥️ browsers:node18.12.0-chrome107 🤖 PR User 🗃️ e2e/*
Project n8n
Branch Review master
Run status status check passed Passed #7083
Run duration 04m 29s
Commit git commit 0ff0f1aa11: 🌳 master 🖥️ browsers:node18.12.0-chrome107 🤖 PR User 🗃️ e2e/*
Committer Elias Meire
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 435
View all changes introduced in this branch ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@ShireenMissi ShireenMissi merged commit 0ff0f1a into master Sep 27, 2024
41 of 42 checks passed
@ShireenMissi ShireenMissi deleted the trigger-node-testing branch September 27, 2024 15:53
MiloradFilipovic added a commit that referenced this pull request Sep 30, 2024
* master:
  feat(Iterable Node): Add support for EDC and USDC selection (#10908)
  test(Schedule Trigger Node): Add tests and extract trigger test helper (no-changelog) (#10625)
  fix(Todoist Node): Fix listSearch filter bug in Todoist Node (#10989)
  fix(AwsS3 Node): Fix search only using first input parameters (#10998)
  fix(editor): Fix bug causing node issues to not be assigned before first interaction (no-changelog) (#10980)
  fix(editor): Allow resources to move between personal and team projects (#10683)
  fix(Respond to Webhook Node): Node does not work with Wait node (#10992)
  fix(core): Upgrade @n8n/typeorm to address a rare mutex release issue (#10993)
  refactor(core): Separate execution `startedAt` from `createdAt` (#10810)
  refactor(core): Make all pubsub messages type-safe (#10990)
  feat(Question and Answer Chain Node): Customize question and answer system prompt (#10385)
  fix(editor): Fix performance issue in credentials list (#10988)
  fix(RSS Feed Trigger Node): Fix regression on missing timestamps (#10991)
  fix(editor): Fix workflow executions list page redirection (#10981)
  fix(editor): Fix filter execution by "Queued" (#10987)
  fix(API): Fix workflow project transfer (#10651)
@janober
Copy link
Member

janober commented Oct 2, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants