-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(Schedule Trigger Node): Add tests and extract trigger test helper (no-changelog) #10625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
Authored by the n8n team
node/improvement
New feature or request
labels
Aug 30, 2024
elsmr
changed the title
refactor: Extract util to test trigger nodes more easily (WIP)
test: Add tests to Schedule Trigger node
Sep 27, 2024
elsmr
changed the title
test: Add tests to Schedule Trigger node
testO: Add tests to Schedule Trigger node
Sep 27, 2024
elsmr
changed the title
testO: Add tests to Schedule Trigger node
test(Schedule Node): Add tests to Schedule Trigger node
Sep 27, 2024
elsmr
changed the title
test(Schedule Node): Add tests to Schedule Trigger node
test(Schedule Trigger Node): Add tests and extract trigger test helper
Sep 27, 2024
ShireenMissi
changed the title
test(Schedule Trigger Node): Add tests and extract trigger test helper
test(Schedule Trigger Node): Add tests and extract trigger test helper (no-changelog)
Sep 27, 2024
ShireenMissi
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
n8n Run #7083
Run Properties:
|
Project |
n8n
|
Branch Review |
master
|
Run status |
Passed #7083
|
Run duration | 04m 29s |
Commit |
0ff0f1aa11: 🌳 master 🖥️ browsers:node18.12.0-chrome107 🤖 PR User 🗃️ e2e/*
|
Committer | Elias Meire |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
435
|
View all changes introduced in this branch ↗︎ |
✅ All Cypress E2E specs passed |
MiloradFilipovic
added a commit
that referenced
this pull request
Sep 30, 2024
* master: feat(Iterable Node): Add support for EDC and USDC selection (#10908) test(Schedule Trigger Node): Add tests and extract trigger test helper (no-changelog) (#10625) fix(Todoist Node): Fix listSearch filter bug in Todoist Node (#10989) fix(AwsS3 Node): Fix search only using first input parameters (#10998) fix(editor): Fix bug causing node issues to not be assigned before first interaction (no-changelog) (#10980) fix(editor): Allow resources to move between personal and team projects (#10683) fix(Respond to Webhook Node): Node does not work with Wait node (#10992) fix(core): Upgrade @n8n/typeorm to address a rare mutex release issue (#10993) refactor(core): Separate execution `startedAt` from `createdAt` (#10810) refactor(core): Make all pubsub messages type-safe (#10990) feat(Question and Answer Chain Node): Customize question and answer system prompt (#10385) fix(editor): Fix performance issue in credentials list (#10988) fix(RSS Feed Trigger Node): Fix regression on missing timestamps (#10991) fix(editor): Fix workflow executions list page redirection (#10981) fix(editor): Fix filter execution by "Queued" (#10987) fix(API): Fix workflow project transfer (#10651)
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-1709/improve-trigger-nodes-testing
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)