Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Wait Node): Append n8n attribution option #10585

Merged
merged 3 commits into from
Aug 30, 2024
Merged

fix(Wait Node): Append n8n attribution option #10585

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c52a747
fix
michael-radency Aug 28, 2024
0c6a017
Merge branch 'master' of https://github.com/n8n-io/n8n into node-1613…
michael-radency Aug 29, 2024
a0ff12c
refactoring
michael-radency Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/nodes-base/nodes/Form/common.descriptions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,3 +314,12 @@ export const respondWithOptions: INodeProperties = {
},
],
};

export const appendAttribution: INodeProperties = {
// eslint-disable-next-line n8n-nodes-base/node-param-display-name-miscased
displayName: 'Append n8n Attribution',
name: 'appendAttribution',
type: 'boolean',
default: true,
description: 'Whether to include the link “Form automated with n8n” at the bottom of the form',
ShireenMissi marked this conversation as resolved.
Show resolved Hide resolved
};
11 changes: 2 additions & 9 deletions packages/nodes-base/nodes/Form/v2/FormTriggerV2.node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import type {

import { formWebhook } from '../utils';
import {
appendAttribution,
formDescription,
formFields,
formRespondMode,
Expand Down Expand Up @@ -115,15 +116,7 @@ const descriptionV2: INodeTypeDescription = {
placeholder: 'Add option',
default: {},
options: [
{
// eslint-disable-next-line n8n-nodes-base/node-param-display-name-miscased
displayName: 'Append n8n Attribution',
name: 'appendAttribution',
type: 'boolean',
default: true,
description:
'Whether to include the link “Form automated with n8n” at the bottom of the form',
},
appendAttribution,
{
...respondWithOptions,
displayOptions: {
Expand Down
5 changes: 3 additions & 2 deletions packages/nodes-base/nodes/Wait/Wait.node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import {
respondWithOptions,
formRespondMode,
formTitle,
appendAttribution,
} from '../Form/common.descriptions';
import { formWebhook } from '../Form/utils';
import { updateDisplayOptions } from '../../utils/utilities';
Expand Down Expand Up @@ -436,7 +437,7 @@ export class Wait extends Webhook {
responseMode: ['responseNode'],
},
},
options: [respondWithOptions, webhookSuffix],
options: [appendAttribution, respondWithOptions, webhookSuffix],
},
{
displayName: 'Options',
Expand All @@ -452,7 +453,7 @@ export class Wait extends Webhook {
responseMode: ['onReceived', 'lastNode'],
},
},
options: [webhookSuffix],
options: [appendAttribution, webhookSuffix],
},
],
};
Expand Down