feat(editor): Implement workflowSelector parameter type #10482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
jeanpaul
reviewed
Aug 21, 2024
packages/@n8n/nodes-langchain/nodes/retrievers/RetrieverWorkflow/RetrieverWorkflow.node.ts
Outdated
Show resolved
Hide resolved
packages/@n8n/nodes-langchain/nodes/retrievers/RetrieverWorkflow/RetrieverWorkflow.node.ts
Show resolved
Hide resolved
jeanpaul
reviewed
Aug 21, 2024
...s/editor-ui/src/components/WorkflowSelectorParameterInput/useWorkflowResourceLocatorModes.ts
Outdated
Show resolved
Hide resolved
packages/editor-ui/src/components/WorkflowSelectorParameterInput/useWorkflowResourcesLocator.ts
Outdated
Show resolved
Hide resolved
packages/editor-ui/src/components/WorkflowSelectorParameterInput/useWorkflowResourcesLocator.ts
Show resolved
Hide resolved
...s/editor-ui/src/components/WorkflowSelectorParameterInput/WorkflowSelectorParameterInput.vue
Outdated
Show resolved
Hide resolved
|
Thanks for the review, @jeanpaul! I've pushed some changes & applied your suggestions. Could you have another look, please? |
jeanpaul
approved these changes
Aug 22, 2024
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
master
|
| Run status |
|
| Run duration | 04m 46s |
| Commit |
|
| Committer | oleg |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
419
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
OlegIvaniv
deleted the
ai-239-make-dropdown-for-specifying-the-workflow-in-the-execute
branch
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements a new parameter input type:
workflowSelector. This parameter functions similarly toresourceLocatorbut doesn't require setting up n8n public API credentials to fetch the workflows. Instead, it utilizes the same front-end endpoint for WorkflowsView and has fixed modes(idandlist). We use this new parameter type forExecuteWorkflow,ToolWorkflowandRetrieverWorkflowby creating a new version to make sure the previous non-rlc values are still working as expected.Since the styles are identical to the
ResourceLocatorcomponent, I've extracted them and used them for both components. Eventually, we might consider refactoring the ResourceLocator component into some pure representation without API fetching logic and usingscript setupsyntax.CleanShot.2024-08-20.at.17.19.30.mp4
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)