Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Remove item count from pinned data status icon in new canvas (no-changelog) #10431

Merged
merged 2 commits into from
Aug 15, 2024
Merged

fix(editor): Remove item count from pinned data status icon in new canvas (no-changelog) #10431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d05e00d
fix: remove item count from pinned data status icon
alexgrozav Aug 15, 2024
efe5005
test: update status icon tests
alexgrozav Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...-ui/src/components/canvas/elements/nodes/render-types/parts/CanvasNodeStatusIcons.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ describe('CanvasNodeStatusIcons', () => {
},
});

expect(getByTestId('canvas-node-status-pinned')).toHaveTextContent('5');
expect(getByTestId('canvas-node-status-pinned')).toBeInTheDocument();
});

it('should render correctly for a running node', () => {
Expand Down
2 changes: 0 additions & 2 deletions ...itor-ui/src/components/canvas/elements/nodes/render-types/parts/CanvasNodeStatusIcons.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import { useCanvasNode } from '@/composables/useCanvasNode';
const nodeHelpers = useNodeHelpers();

const {
pinnedDataCount,
hasPinnedData,
issues,
hasIssues,
Expand Down Expand Up @@ -51,7 +50,6 @@ const hideNodeIssues = computed(() => false); // @TODO Implement this
:class="[$style.status, $style.pinnedData]"
>
<FontAwesomeIcon icon="thumbtack" />
<span v-if="pinnedDataCount > 1" :class="$style.count"> {{ pinnedDataCount }}</span>
</div>
<div v-else-if="executionStatus === 'unknown'">
<!-- Do nothing, unknown means the node never executed -->
Expand Down
Loading