Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Fix bug causing workflow debugging to not work in new canvas (no-changelog) #10384

Merged
merged 3 commits into from
Aug 13, 2024
Merged

fix(editor): Fix bug causing workflow debugging to not work in new canvas (no-changelog) #10384

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d87f9a3
fix: fix bug causing workflow debugging to not work in new canvas
alexgrozav Aug 13, 2024
3015ac8
chore: remove unused type
alexgrozav Aug 13, 2024
4b44952
chore: remove unused constant
alexgrozav Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion packages/editor-ui/src/views/NodeView.v2.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import {
onMounted,
ref,
useCssModule,
watch,
} from 'vue';
import { useRoute, useRouter } from 'vue-router';
import WorkflowCanvas from '@/components/canvas/WorkflowCanvas.vue';
Expand Down Expand Up @@ -288,6 +289,7 @@ async function initializeRoute() {
nodeHelpers.updateNodesParameterIssues();

await loadCredentials();
await initializeDebugMode();
}

async function initializeWorkspaceForNewWorkflow() {
Expand All @@ -306,7 +308,6 @@ async function initializeWorkspaceForExistingWorkflow(id: string) {
const workflowData = await workflowsStore.fetchWorkflow(id);

await openWorkflow(workflowData);
await initializeDebugMode();

if (workflowData.meta?.onboardingId) {
trackOpenWorkflowFromOnboardingTemplate();
Expand Down Expand Up @@ -748,6 +749,7 @@ async function importWorkflowExact({ workflow: workflowData }: { workflow: IWork

resetWorkspace();

await initializeData();
await initializeWorkspace({
...workflowData,
nodes: NodeViewUtils.getFixedNodesList<INodeUi>(workflowData.nodes),
Expand Down Expand Up @@ -1370,6 +1372,21 @@ function registerCustomActions() {
// });
}

/**
* Routing
*/

watch(
() => route.name,
async () => {
if (!checkIfEditingIsAllowed()) {
return;
}

await initializeRoute();
},
);

/**
* Lifecycle
*/
Expand Down
Loading