Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): Decouple LDAP from internal hooks (no-changelog) #10157

Merged
merged 4 commits into from
Jul 24, 2024

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Jul 23, 2024

Follow-up to #10152

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Jul 23, 2024
RicardoE105
RicardoE105 previously approved these changes Jul 24, 2024
Copy link
Contributor

@RicardoE105 RicardoE105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link

cypress bot commented Jul 24, 2024

Passing run #6120 ↗︎

0 387 0 0 Flakiness 0

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃️ e2e/*
Project: n8n Commit: 76fcbc13ec
Status: Passed Duration: 04:10 💡
Started: Jul 24, 2024 7:38 AM Ended: Jul 24, 2024 7:42 AM

Review all test suite changes for PR #10157 ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link
Contributor

✅ All Cypress E2E specs passed

@ivov ivov merged commit dea2126 into master Jul 24, 2024
28 checks passed
@ivov ivov deleted the decouple-ldap-from-internal-hooks branch July 24, 2024 07:49
@janober
Copy link
Member

janober commented Jul 24, 2024

Got released with [email protected]

cstuncsik pushed a commit that referenced this pull request Jul 31, 2024
cstuncsik pushed a commit that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants