Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): Centralize CronJob management #10033

Merged
merged 20 commits into from
Jul 16, 2024
Merged

refactor(core): Centralize CronJob management #10033

merged 20 commits into from
Jul 16, 2024

Commits on Jul 15, 2024

  1. fix typos on "recurrence"

    @netroy
    netroy committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    eac7c75 View commit details
    Browse the repository at this point in the history

  2. refactor(core): Centralize CronJob management

    @netroy
    netroy committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    e387cec View commit details
    Browse the repository at this point in the history

  3. update toCronExpression, and add tests

    @netroy
    netroy committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    7a49bd7 View commit details
    Browse the repository at this point in the history

  4. some unit tests for recurrenceCheck

    @netroy
    netroy committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    a32519e View commit details
    Browse the repository at this point in the history

  5. Do not setup actual crons in manual executions

    @netroy
    netroy committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    5ae64f8 View commit details
    Browse the repository at this point in the history

  6. more tests for recurrenceCheck

    @netroy
    netroy committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    b378bff View commit details
    Browse the repository at this point in the history

  7. make displayed timezone less confusing

    @netroy
    netroy committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    aebdfec View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'origin/master' into global-registry-cron

    @netroy
    netroy committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    84f108f View commit details
    Browse the repository at this point in the history

  9. improve the rendered timezone even more

    @netroy
    netroy committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    574dff8 View commit details
    Browse the repository at this point in the history

  10. extract intervalToRecurrence, add unit tests, and use the first rule … 

    …in manual testing
    @netroy
    netroy committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    f3864c4 View commit details
    Browse the repository at this point in the history

  11. Merge remote-tracking branch 'origin/master' into global-registry-cron

    @netroy
    netroy committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    86ae5c6 View commit details
    Browse the repository at this point in the history

  12. validate user defined cron expressions in manual executions as well

    @netroy
    netroy committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    23d3128 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Merge remote-tracking branch 'origin/master' into global-registry-cron

    @netroy
    netroy committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    00ab906 View commit details
    Browse the repository at this point in the history

  2. workflow timezone doesn't change.

    @netroy
    netroy committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    12dd52f View commit details
    Browse the repository at this point in the history

  3. improve CronExpression type

    @netroy
    netroy committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    d6a6a2d View commit details
    Browse the repository at this point in the history

  4. scatter triggers on the old cron node as well, to prevent all "every … 

    …hour" crons from all triggering at the same minute
    @netroy
    netroy committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    a600fcd View commit details
    Browse the repository at this point in the history

  5. address PR feedback

    @netroy
    netroy committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    d49e6c4 View commit details
    Browse the repository at this point in the history

  6. fix old Cron tests

    @netroy
    netroy committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    a224cf7 View commit details
    Browse the repository at this point in the history

  7. do not return manualTriggerFunction for non-manual executions

    @netroy
    netroy committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    2b72adb View commit details
    Browse the repository at this point in the history

  8. add unit tests for the ScheduleTrigger node

    @netroy
    netroy committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    d0192f3 View commit details
    Browse the repository at this point in the history