fix(core): Throw on adding execution without execution data #9903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivov
added
the
release/backport
ivov
changed the title
n8n-assistant
bot
added
core
ivov
changed the title
netroy
previously approved these changes
Jul 1, 2024
|
|
netroy
previously approved these changes
Jul 1, 2024
|
|
netroy
approved these changes
Jul 2, 2024
|
✅ All Cypress E2E specs passed |
cstuncsik
pushed a commit
that referenced
this pull request
Jul 3, 2024
Merged
ivov
added a commit
that referenced
this pull request
Jul 3, 2024
Merged
|
Got released with |
Merged
adrian-martinez-onestic
pushed a commit
to onesdata/n8n-fork
that referenced
this pull request
Jul 8, 2024
tomi
added a commit
that referenced
this pull request
Aug 1, 2024
Executions and their data are inserted in two separate insert statements. Before this PR, this wasn't done in a transaction, which could cause executions to be created without execution data. This caused issues like the one fixed in #9903.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Re-enqueuing of executions on startup appears to be causing an issue when execution data is
null. Cannot reproduce locally yet, so for now we throw on adding an execution without execution data so we can diagnose what kinds of workflows cna cause this.Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/PAY-1715
https://community.n8n.io/t/error-starting-1-47-0/49084
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)