fix: Change the UI text for some filter operations #8360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joffcom
previously approved these changes
Jan 17, 2024
n8n-assistant
bot
added
n8n team
|
✅ All Cypress E2E specs passed |
1 flaky test on run #3811 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > resolves expression with default item when input node is not parent, while still pairing items |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #8360 ↗︎
… into switch-text-suggestions
Joffcom
approved these changes
Jan 18, 2024
|
✅ All Cypress E2E specs passed |
|
Got released with |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
X or equalshould beX or equal to. For example, changelength greater than or equaltolength greater than or equal to. Reason: in the filter component, it looks like we're trying to create natural sounding sentences for the comparisons. For example, in the switch node, you can compare two strings withis equal toso you end up withx is equal to y. However, a few of the options are missing theto, and it reads oddly.