Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BambooHR node does not allow to set onlyCurrent option. #7876

Closed
oleksandrborniak opened this issue Nov 29, 2023 · 5 comments
Closed

BambooHR node does not allow to set onlyCurrent option. #7876

oleksandrborniak opened this issue Nov 29, 2023 · 5 comments
Assignees
Labels

Comments

@oleksandrborniak
Copy link

Describe the bug
The BambooHR node, Resource: Company Report, Operation: Get does not allow choose "onlyCurrent" option.
Screenshot 2023-11-29 at 22 34 03
Screenshot 2023-11-29 at 22 31 34

To Reproduce
Steps to reproduce the behavior:
Try to set "onlyCurrent" option in BambooHR node, Resource: Company Report, Operation: Get

Expected behavior
I should be able to choose "onlyCurrent" option.
https://api.bamboohr.com/api/gateway.php/DOMAIN/v1/reports/ReportID?onlyCurrent=false

Environment (please complete the following information):

OS: MacOS
n8n Version: 1.17.1
Database system: SQLite

@Joffcom
Copy link
Member

Joffcom commented Nov 29, 2023

Hey @oleksandrborniak,

Thanks for the report, this sounds more like a feature request than a bug to me so this would be better suited to the feature request section of the community support forum.

Could you let me know if you consider this to be a bug and if that is the case we can keep it open rather than close it.

@Joffcom Joffcom self-assigned this Nov 29, 2023
@oleksandrborniak
Copy link
Author

Hello Jon,
I would create a future request, but I think there it would be considered much longer.
Adding "?onlyCurrent" to the end of the query URL seems like an easy task and I would do it myself - but I'm new to the program and don't have enough knowledge to do it yet.
If you don't mind I'd leave it open here, but of course, if it's not very convenient I'll close this issue and make a future request.
Thank you!

@Joffcom
Copy link
Member

Joffcom commented Nov 30, 2023

Hey @oleksandrborniak,

While adding it may seem like an easy task we use the forum for tracking feature requests to prioritise them based on what the community are after, This can lead to requests sometimes taking longer to implement but we have a lot of requests and our own roadmap items to implement.

That being said I have created PR which can be found below that will add this feature but we will start to be stricter on this soon and close issues that are feature requests and not bugs.

#7878

@oleksandrborniak
Copy link
Author

Thanks for the clarification and assistance.
I made a note and will pay attention to it in the future.
Have a nice day.

Joffcom added a commit that referenced this issue Dec 5, 2023
…7878)

Github issue / Community forum post (link here to close automatically):
#7876

API Docs for reference:
https://documentation.bamboohr.com/reference/get-company-report-1
@janober
Copy link
Member

janober commented Dec 6, 2023

Fix got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants