fix(editor): Make Source control branch select required #6619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Files matching
Make sure to check off this list before asking for review. |
n8n-assistant
bot
added
n8n team
alexgrozav
approved these changes
Jul 7, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6619 +/- ##
==========================================
- Coverage 28.91% 28.85% -0.06%
==========================================
Files 3069 3069
Lines 188330 188357 +27
Branches 20890 20890
==========================================
- Hits 54455 54357 -98
- Misses 132995 133120 +125
Partials 880 880
☔ View full report in Codecov by Sentry. |
2 flaky tests on run #1399 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Canvas Node Manipulation and Navigation > should disable node by pressing the disable button |
Output
Screenshots
Video
|
|
9-expression-editor-modal.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Expression editor modal > should resolve array resolvables |
Output
Screenshots
Video
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
|
✅ All Cypress E2E specs passed |
alexgrozav
deleted the
pay-603-source-control-branch-selector-input-required
branch
MiloradFilipovic
added a commit
that referenced
this pull request
Jul 7, 2023
* master: fix(editor): Make Source control branch select required (#6619) refactor(core): Load `cookieParser` middleware only once (no-changelog) (#6614) fix(editor): Prevent keyboard shortcuts to edit workflows in readonly mode (#6613) fix(editor): Show appropriate empty workflow list content when instance environment is readonly (#6610) ci: Fix linting issues (no-changelog)
MiloradFilipovic
added a commit
that referenced
this pull request
Jul 7, 2023
* ADO-814-trial-banner: (58 commits) ⚡ Updating permanent dismiss logic to work with all banners fix(editor): Make Source control branch select required (#6619) ⚡ Minor refactoring of banner logic refactor(core): Load `cookieParser` middleware only once (no-changelog) (#6614) fix(editor): Prevent keyboard shortcuts to edit workflows in readonly mode (#6613) fix(editor): Show appropriate empty workflow list content when instance environment is readonly (#6610) ✨ Implemented permanent/temporary dismiss logic for v1 flag ci: Fix linting issues (no-changelog) fix(Google Drive Node): Fix regex in file RLC (#6607) feat(HTML Node): 'Convert to table operation (#6540) ci: e2e tests don't need to enable saving manual executions 🚀 Release 1.0.1 (#6606) fix(core): Make node execution order configurable, and backward-compatible (#6507) 🚀 Release 0.236.0 (#6602) fix: Fix migrations for postgres and mysql (no-changelog) (#6600) fix(core): Improve the performance of last 2 sqlite migrations (#6522) refactor: Switch cloud plan retrieval endpoint (no-changelog) (#6529) fix(Salesforce Node): Fix typo for adding a contact to a campaign (#6598) ci: Hide v1 banner in e2e tests to fix 2-credentials.cy.ts (no-changelog) fix(editor): Restore expression completions (#6566) ...
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.