fix(editor): Remove explicit parameter name scanning for code editors #6390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The correct value to display in an editor is already passed in to `ParameterInput`. We do not need to scan for the correct parameter name again. This also fixes the issue of us accidentally using `jsCode` as the parameter name in the Code node when the language is set to Python.
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Files matching
Make sure to check off this list before asking for review. |
n8n-assistant
bot
added
n8n team
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6390 +/- ##
==========================================
- Coverage 28.33% 28.25% -0.09%
==========================================
Files 2980 2980
Lines 184930 184913 -17
Branches 20306 20300 -6
==========================================
- Hits 52406 52248 -158
- Misses 131738 131879 +141
Partials 786 786
☔ View full report in Codecov by Sentry. |
MiloradFilipovic
approved these changes
Jun 6, 2023
1 flaky tests on run #1116 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Data pinning > Should be able to set pinned data |
Output
Screenshots
Video
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
|
✅ All Cypress E2E specs passed |
MiloradFilipovic
added a commit
that referenced
this pull request
Jun 13, 2023
* master: test(editor): Unit test Version control frontend components (#6408) fix: Fist name to First Name in certain nodes (no-changelog) (#6404) fix(core): Allow all executions to be stopped (#6386) fix(core): RMC boolean value fix (#6397) fix(editor): Remove root level tag selector from css module to avoid making it a global style (#6392) fix(Ldap Node): Add DN field to update operation (#6371) feat: New trigger PostgreSQL (#5495) build: Update pnpm lock file (no-changelog) (#6395) fix(Date & Time Node): Reset responseData at end of loop (#6385) refactor(core): Google service account remove duplicated functions (no-changelog) (#6368) refactor(LoneScale List Node)!: Rename to LoneScale (#6337) fix(editor): Update version control setup CTA tooltip (#6393) ci: Fix build (no-changelog) (#6391) fix(editor): Add button to refresh branches (#6387) fix(editor): Add Set up version control CTA (#6356) fix(editor): Remove explicit parameter name scanning for code editors (#6390) ci: Fix build (no-changelog) (#6379) fix(editor): Adding branch color (#6380) refactor(editor): Remove user activation modal (no-changelog) (#6361) feat(editor): Change upgrade CTA on community editions (no-changelog) (#6317)
|
Got released with |
netroy
added a commit
that referenced
this pull request
Jun 14, 2023
…#6390) The correct value to display in an editor is already passed in to `ParameterInput`. We do not need to scan for the correct parameter name again. This also fixes the issue of us accidentally using `jsCode` as the parameter name in the Code node when the language is set to Python.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The correct value to display in an editor is already passed in to
ParameterInput. We do not need to scan for the correct parameter name again. This also fixes the issue of us accidentally usingjsCodeas the parameter name in the Code node when the language is set to Python.NODE-558
https://community.n8n.io/t/python-code-is-not-saved-once-the-configuration-dialog-is-dismissed/26586
https://community.n8n.io/t/python-support-and-release-versions/26291/6?u=jan