fix(editor): Fix hard-coded parameter names for code editors #6372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Files matching
Make sure to check off this list before asking for review. |
netroy
reviewed
Jun 2, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6372 +/- ##
==========================================
- Coverage 28.33% 28.24% -0.09%
==========================================
Files 2982 2982
Lines 185187 185204 +17
Branches 20304 20298 -6
==========================================
- Hits 52464 52308 -156
- Misses 131936 132109 +173
Partials 787 787
☔ View full report in Codecov by Sentry. |
netroy
reviewed
Jun 2, 2023
netroy
reviewed
Jun 2, 2023
netroy
reviewed
Jun 2, 2023
n8n-assistant
bot
added
n8n team
|
|
1 flaky tests on run #1088 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Workflow tags > should detach a tag inline by clicking on X on tag pill |
Output
Screenshots
Video
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
|
✅ All Cypress E2E specs passed |
MiloradFilipovic
added a commit
that referenced
this pull request
Jun 2, 2023
* master: fix(editor): Fix hard-coded parameter names for code editors (#6372) ci: Add support for Node.js 18 (#5793) ci: Update the release process for v1 release (#6366) refactor: Add deprecation notice for UM disabled mode (#6367) feat(editor): Make WF name a link on /executions (#6354) ci: Revert "Set up Turborepo cache for GitHub actions runner" (#6364) (no-changelog) fix(editor): Add secondary icon to menu items (#6351) fix(editor): Pin all data regardless of pagination (#6346) feat(Crypto Node): Add support for hash and hmac on binary data (#6359) ci: Set up Turborepo cache for GitHub actions runner (no-changelog) (#6335) # Conflicts: # packages/editor-ui/src/components/ParameterInput.vue
|
Got released with |
netroy
pushed a commit
that referenced
this pull request
Jun 14, 2023
* fix(editor): Fix hard-coded parameter names for code editors * ⚡ Adding computed property for editor content * 👌 Refactoring based on the code review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in the Linear ticket, our Vue components had hard-coded values for node properties that contain editor values (
query,jsCodeandhtml).This PR fixes that by searching for node properties with appropriate editor set in
typeOptionsand uses found property name to extract it's value.