feat(Set Node): Overhaul #6348
Merged
feat(Set Node): Overhaul #6348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-radency
added
node/improvement
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Files matching
Files matching
Files matching
Files matching
Make sure to check off this list before asking for review. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6348 +/- ##
==========================================
+ Coverage 32.65% 32.69% +0.03%
==========================================
Files 3340 3346 +6
Lines 199463 199748 +285
Branches 21850 21889 +39
==========================================
+ Hits 65133 65298 +165
- Misses 133250 133355 +105
- Partials 1080 1095 +15
☔ View full report in Codecov by Sentry. |
|
it would be nice to have an option to remove some fields |
…set-node-overhaul
…set-node-overhaul
…set-node-overhaul
…set-node-overhaul
…set-node-overhaul
…set-node-overhaul
maspio
previously approved these changes
Sep 18, 2023
…set-node-overhaul
|
|
2 flaky tests on run #2210 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > resolves expression with default item when input node is not parent, while still pairing items |
Output
Screenshots
Video
|
|
28-debug.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Debug > should be able to debug executions |
Output
Screenshots
Video
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
MiloradFilipovic
previously approved these changes
Sep 18, 2023
There was a problem hiding this comment.
Looking good, thanks for addressing previous comments, @michael-radency 🙌
There is one minor thing that I noticed but ultimately it's a product decision:
When Ignore type conversion is turned on, inline validation errors (warnings next to inputs) are still showing up which could look confusing to users:
|
|
michael-radency
dismissed stale reviews from MiloradFilipovic and maspio
via
275b247
maspio
previously approved these changes
Sep 19, 2023
|
|
maspio
approved these changes
Sep 19, 2023
|
✅ All Cypress E2E specs passed |
Merged
krynble
added a commit
that referenced
this pull request
Sep 20, 2023
# [1.8.0](https://github.com/n8n-io/n8n/compare/[email protected]@1.8.0) (2023-09-20) ### Bug Fixes * **core:** Make parsing of content-type and content-disposition headers more flexible ([#7217](#7217)) ([d41546b](d41546b)), closes [#7149](#7149) * **core:** Resolve domains to IPv4 first ([#7206](#7206)) ([e9ce531](e9ce531)) * **editor:** Add ssh key type selection to source control settings when regenerating key ([#7172](#7172)) ([54bf66d](54bf66d)) * **editor:** No need to add click emitting click events, VUE delegates the handler to the root element of the component ([#7182](#7182)) ([3c055e4](3c055e4)) * **editor:** Prevent duplicate creation of credential for OAuth2 ([#7163](#7163)) ([07a6417](07a6417)) * **editor:** Testing flaky resource mapper feature in e2e tests ([#7165](#7165)) ([aaf87c3](aaf87c3)) * **HTML Node:** Add pairedItem support for 'Convert to HTML Table' operation ([#7196](#7196)) ([6bc477b](6bc477b)) * **HTTP Request Node:** Decrease default timeout to 5min ([#7177](#7177)) ([321780d](321780d)) * **seven Node:** Rename sms77 to seven, fix credentials test ([#7180](#7180)) ([cf776b8](cf776b8)) * **X (Formerly Twitter) Node:** Rename Twitter to X (keep Twitter alias) ([#7179](#7179)) ([d317e09](d317e09)) ### Features * **core:** Add command to trigger license refresh on workers ([#7184](#7184)) ([9f797b9](9f797b9)) * **core:** Add rsa option to ssh key generation ([#7154](#7154)) ([fdac2c8](fdac2c8)) * **Linear Node:** Add support for OAuth2 ([#7201](#7201)) ([12a3168](12a3168)) * **Microsoft Outlook Node:** Node overhaul ([#4449](#4449)) ([556a613](556a613)) * **Set Node:** Overhaul ([#6348](#6348)) ([3a47455](3a47455)) Co-authored-by: krynble <[email protected]>
MiloradFilipovic
added a commit
that referenced
this pull request
Sep 20, 2023
* master: refactor(core): Implement soft-deletions for executions (#7092) docs(Google Sheets Node): Operations naming update (no-changelog) (#7211) fix(core): Make parsing of content-type and content-disposition headers more flexible (#7217) fix(HTML Node): Add pairedItem support for 'Convert to HTML Table' operation (#7196) fix(HTTP Request Node): Decrease default timeout to 5min (#7177) feat(Linear Node): Add support for OAuth2 (#7201) refactor: Ignore large-scale revisions (no-changelog) (#7210) fix(core): Resolve domains to IPv4 first (#7206) ci: Fix tests failing on MySQL (no-changelog) (#7208) feat(Set Node): Overhaul (#6348) fix: Attempt license renewal when n8n starts (no-changelog) (#7204)
|
Got released with |
|
In 1.8.2, this Set node messes with null and undefined values. See this thread. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github issue / Community forum post (link here to close automatically): #6348