Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SSH Node): Private key field as password and credential test #6298

Conversation

michael-radency
Copy link
Contributor

Github issue / Community forum post (link here to close automatically):

@michael-radency michael-radency added n8n team Authored by the n8n team node/issue Issue with a node labels May 23, 2023
@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Make sure to check off this list before asking for review.

Sorry, something went wrong.

@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (4d9c8b0) 27.65% compared to head (4dd15ae) 27.65%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6298      +/-   ##
==========================================
- Coverage   27.65%   27.65%   -0.01%     
==========================================
  Files        2948     2948              
  Lines      180885   180889       +4     
  Branches    19647    19647              
==========================================
  Hits        50019    50019              
- Misses     130119   130123       +4     
  Partials      747      747              
Impacted Files Coverage Δ
...odes-base/credentials/SshPrivateKey.credentials.ts 0.00% <ø> (ø)
packages/nodes-base/nodes/Ssh/Ssh.node.ts 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@michael-radency michael-radency merged commit d5c7e6f into master May 23, 2023
@michael-radency michael-radency deleted the node-518-ssh-pk-dont-mess-up-newlines-on-private-key-paste branch May 23, 2023 09:01
eyaljoyous pushed a commit to eyaljoyous/n8n that referenced this pull request May 23, 2023

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
* allow execution on  node 19,20,22

* fix(ERPNext Node): Fix issue with credential test and add frappe cloud url (n8n-io#6283)

* fix(editor): UI copy fix for Date & Time node (no-changelog) (n8n-io#6291)

* whether -> when

* lint fix

---------

Co-authored-by: Jonathan Bennetts <jonathan.bennetts@gmail.com>

* feat(RabbitMQ Node): Add mode for acknowledging and deleting from queue later in workflow (n8n-io#6225)

* Add later in workflow mode

* Add new operation

* Acknowledge message in next node

* Add response and emit for responsePromiseHook

* Remove double success message, close channel correctly

* Answser messages correctly

* Remove option from delete operation

* move operation name to camelCase

* Fix versioning

* To remove: add action item in v1

* Add notice for delete from queue

* Correctly only execute only the delete operation

* Refactor delete from queue operator and add return last items

---------

Co-authored-by: Marcus <marcus@n8n.io>

* feat: Add dangerouslyUseHTMLString where needed (no-changelog) (n8n-io#6292)

feat: add dangerouslyUseHTMLString where needed (no-changelog)

* fix(Wekan Node): Handle response correctly (n8n-io#6296)

Fix bug when response wasn't array

* Added procfile

* Added procfile

* redployed

* redployed

* redployed

* redployed

* redployed

* redployed

* dont start

* redployed

* redployed

* update version

* redployed

* redployed

* redployed

* redployed

* Revert "update version"

This reverts commit c249585.

* add heroku stack version

* delete

* add app.json setting heroku build stack

* update

* update vite

* update mem

* update PORT

* redployed

* fix(core): Optimize SharedWorkflow queries (n8n-io#6297)

* optimize SharedWorkflow queries

* fix int to string ids

* fix(Strapi Node): Strapi credentials notice (n8n-io#6289)

* fix(SSH Node): Private key field as password and credential test (n8n-io#6298)

* fix: Prevent removing manual executions when setting says to save (n8n-io#6300)

* fix: Initialize license in queue mode correctly (n8n-io#6301)

* feat(Ldap Node): Add LDAP node (n8n-io#4783)

* feat(LoneScale Node): Add LoneScale node and Trigger node (n8n-io#5146)

* feat: Add SSO SAML metadataUrl support and various improvements (n8n-io#6139)

* feat: add various sso improvements

* fix: remove test button assertion

* fix: fix type imports

* test: attempt fixing unit tests

* fix: changed to using useToast for error toasts

* Minor copy tweaks and swapped buttons position.

* fix locale ref

* align error with UI wording

* simplify saving ux

* fix pretty

* fix: update saml sso setting saving

* fix: undo try/catch changes when saving saml config

* metadata url tab selected at first

* chore: fix linting issue

* test: fix activation checkbox test

---------

Co-authored-by: Giulio Andreini <g.andreini@gmail.com>
Co-authored-by: Michael Auerswald <michael.auerswald@gmail.com>
Co-authored-by: Romain Minaud <romain.minaud@gmail.com>

* fix(editor): Fix canvas loading when page gets restored from bfcache (n8n-io#6304)

* fix(editor): Fix canvas loading when page gets restored from bfcache

* Lint fix

* fix(editor): Link to log streaming doc from log streaming (no-changelog) (n8n-io#6303)

link to log streaming doc from log streaming

---------

Co-authored-by: Eyal Fishler <eyalfishler@gmail.com>
Co-authored-by: Jon <jonathan.bennetts@gmail.com>
Co-authored-by: Deborah <deborah@starfallprojects.co.uk>
Co-authored-by: agobrech <45268029+agobrech@users.noreply.github.com>
Co-authored-by: Marcus <marcus@n8n.io>
Co-authored-by: Alex Grozav <alex@grozav.com>
Co-authored-by: Omri Attoun <omri@joyous.team>
Co-authored-by: Michael Auerswald <michael.auerswald@gmail.com>
Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: Yann ALEMAN <yann.aleman27@gmail.com>
Co-authored-by: Giulio Andreini <g.andreini@gmail.com>
Co-authored-by: Romain Minaud <romain.minaud@gmail.com>
Co-authored-by: OlegIvaniv <me@olegivaniv.com>
@janober
Copy link
Member

janober commented May 25, 2023

Got released with n8n@0.230.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/issue Issue with a node Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants