Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Compression Node): Fix issue with decompression failing with uppercase extensions #6098

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

Joffcom
Copy link
Member

@Joffcom Joffcom commented Apr 27, 2023

Github issue / Community forum post (link here to close automatically): https://community.n8n.io/t/issue-with-unzipping-a-zip-file-in-an-n8n-workflow/25577

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Make sure to check off this list before asking for review.

Copy link
Contributor

@that-one-tom that-one-tom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that's some sweet file extension handling right here 👍

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Apr 27, 2023
@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c65ac03) 19.18% compared to head (d62e3a3) 19.18%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6098   +/-   ##
=======================================
  Coverage   19.18%   19.18%           
=======================================
  Files        2589     2589           
  Lines      116876   116876           
  Branches    18337    18337           
=======================================
  Hits        22426    22426           
  Misses      93805    93805           
  Partials      645      645           
Impacted Files Coverage Δ
...s/nodes-base/nodes/Compression/Compression.node.ts 67.60% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@Joffcom Joffcom merged commit aa59329 into master Apr 27, 2023
@Joffcom Joffcom deleted the node-500-compression-decompress-fails-for branch April 27, 2023 10:18
MiloradFilipovic added a commit that referenced this pull request Apr 27, 2023
* master:
  fix(editor): Remove pagination from binary data output (#6093)
  fix(editor): Show error in RLC if credentials are not set (#6108)
  fix(editor): Loading state for executions tab (#6100)
  ci: Additionally checkout PR head for e2e tests (no-changelog) (#6105)
  fix(core): Skip auth for controllers/routes that don't use the `Authorized` decorator, or use `Authorized('none')` (#6106)
  fix(editor): Disable changing of email and pw when SAML login enabled (#6104)
  fix(HTTP Request Node): Always lowercase headers
  fix(Compression Node): Fix issue with decompression failing with uppercase extensions (#6098)
  fix(Mattermost Node): Fix base url trailing slash error (#6097)
  feat(Item Lists Node): Split out items work on objects as well as arrays
netroy pushed a commit that referenced this pull request May 2, 2023
@janober
Copy link
Member

janober commented May 2, 2023

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants