Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix n8n-checkbox alignment #6004

Merged
merged 3 commits into from
Apr 19, 2023
Merged

Conversation

alexgrozav
Copy link
Member

image

image

@github-actions
Copy link
Contributor

github-actions bot commented Apr 18, 2023

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching **/*.vue:

  • Used composition API for all new components.
  • Added component or unit tests to cover functionality.

Files matching packages/design-system/**/*.vue:

  • Used design system tokens (colors, spacings...) where possible.
  • Updated Storybook with new component or updated functionality.

Make sure to check off this list before asking for review.

OlegIvaniv
OlegIvaniv previously approved these changes Apr 18, 2023
@@ -190,6 +190,7 @@
position: relative;
border: var.$checkbox-input-border;
border-radius: var.$checkbox-border-radius;
margin-top: 2px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: --spacing-5xs 😛

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed this one! Can you reapprove? Thank you!

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Apr 18, 2023
@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (33299ca) 18.49% compared to head (aab8256) 18.49%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6004   +/-   ##
=======================================
  Coverage   18.49%   18.49%           
=======================================
  Files        2563     2563           
  Lines      116018   116018           
  Branches    18118    18118           
=======================================
  Hits        21458    21458           
  Misses      93930    93930           
  Partials      630      630           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@alexgrozav alexgrozav merged commit f544826 into master Apr 19, 2023
@alexgrozav alexgrozav deleted the pay-349-fix-checkbox-alignment branch April 19, 2023 08:37
sunilrr pushed a commit to fl-g6/qp-n8n that referenced this pull request Apr 24, 2023
* fix: fix n8n-checkbox alignment

* fix: use css variables in checkbox inner margin-top

* test: update snapshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants