fix(editor): Make sure to redirect to blank canvas after personalisation modal #5980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Files matching
Make sure to check off this list before asking for review. |
cstuncsik
approved these changes
Apr 14, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #5980 +/- ##
==========================================
- Coverage 18.07% 18.07% -0.01%
==========================================
Files 2540 2540
Lines 115391 115409 +18
Branches 17990 17991 +1
==========================================
Hits 20860 20860
- Misses 93903 93921 +18
Partials 628 628 see 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
n8n-assistant
bot
added
n8n team
|
✅ All Cypress E2E specs passed |
MiloradFilipovic
added a commit
that referenced
this pull request
Apr 18, 2023
* master: (30 commits) feat(core): Add versionControl feature flag (#6000) fix: Small changes to user activation modal (no-changelog) (#5962) fix(editor): Cleanup demo/video experiment (#5974) feat: Add variables feature (#5602) ci: Improve test for wait node (#5997) fix(editor): Fix moving canvas on middle click preventing lasso selection (#5996) fix(HTTP Request Node): Fix itemIndex in HTTP Request errors (#5991) refactor(editor): Refactor history and debounce mixins to composables (no-changelog) (#5930) feat(GitLab Node): Add Additional parameters for File List (#5621) build: Update license SDK to v2.1.0 (no-changelog) (#5987) fix(OpenAI Node): Update OpenAI Text Moderate input placeholder text (#5823) fix(Code Node): Handle user code returning `null` and `undefined` (#5989) fix(Google Sheets Trigger Node): Return actual error message fix(core): Make `getExecutionId` available on all nodes types (#5990) ci: Add checklist item hinting at not adding new dependencies for nodes (no-changelog) (#5985) fix(core): Improve SAML connection test result views (#5981) fix(IF Node): Fix typo in combine description (no-changelog) (#5964) ci: Add a workflow to push n8n releases to release channels (no-changelog) (#5839) fix(editor): Make sure to redirect to blank canvas after personalisation modal (#5980) fix(core): Fix paired item returning wrong data (#5898) ... # Conflicts: # packages/editor-ui/src/Interface.ts
MiloradFilipovic
added a commit
that referenced
this pull request
Apr 18, 2023
…rce-mapper-ui * feature/resource-mapping-component: (30 commits) feat(core): Add versionControl feature flag (#6000) fix: Small changes to user activation modal (no-changelog) (#5962) fix(editor): Cleanup demo/video experiment (#5974) feat: Add variables feature (#5602) ci: Improve test for wait node (#5997) fix(editor): Fix moving canvas on middle click preventing lasso selection (#5996) fix(HTTP Request Node): Fix itemIndex in HTTP Request errors (#5991) refactor(editor): Refactor history and debounce mixins to composables (no-changelog) (#5930) feat(GitLab Node): Add Additional parameters for File List (#5621) build: Update license SDK to v2.1.0 (no-changelog) (#5987) fix(OpenAI Node): Update OpenAI Text Moderate input placeholder text (#5823) fix(Code Node): Handle user code returning `null` and `undefined` (#5989) fix(Google Sheets Trigger Node): Return actual error message fix(core): Make `getExecutionId` available on all nodes types (#5990) ci: Add checklist item hinting at not adding new dependencies for nodes (no-changelog) (#5985) fix(core): Improve SAML connection test result views (#5981) fix(IF Node): Fix typo in combine description (no-changelog) (#5964) ci: Add a workflow to push n8n releases to release channels (no-changelog) (#5839) fix(editor): Make sure to redirect to blank canvas after personalisation modal (#5980) fix(core): Fix paired item returning wrong data (#5898) ...
sunilrr
pushed a commit
to fl-g6/qp-n8n
that referenced
this pull request
Apr 24, 2023
…ion modal (n8n-io#5980) * fix(editor): Make sure to redirect to blank canvas after personalization modal * Linting fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On cloud instances, there's no owner setup flow happening, so a new user might not end-up on blank canvas as intended. For this we do the router replace after closing of the personalisation modal.