Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(OpenAI Node): Update OpenAI Text Moderate input placeholder text #5823

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

eddywashere
Copy link
Contributor

I thought this was a weird input placeholder to see:

image

So I grabbed a more chill example from https://platform.openai.com/examples/default-adv-tweet-classifier.

@CLAassistant
Copy link

CLAassistant commented Mar 30, 2023

CLA assistant check
All committers have signed the CLA.

@n8n-assistant n8n-assistant bot added community Authored by a community member node/improvement New feature or request labels Mar 30, 2023
@netroy netroy changed the title Update OpenAI Text Moderate input placeholder text fix(OpenAI Node): Update OpenAI Text Moderate input placeholder text Mar 30, 2023
@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (6c35ffa) 14.84% compared to head (b0dc470) 14.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5823      +/-   ##
==========================================
- Coverage   14.84%   14.84%   -0.01%     
==========================================
  Files        2475     2475              
  Lines      113368   113368              
  Branches    17691    17691              
==========================================
- Hits        16831    16825       -6     
- Misses      95997    96006       +9     
+ Partials      540      537       -3     
Impacted Files Coverage Δ
...ackages/nodes-base/nodes/OpenAi/TextDescription.ts 0.00% <ø> (ø)

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Joffcom
Copy link
Member

Joffcom commented Apr 17, 2023

Hey @eddywashere,

Thanks for the PR, This is about to be merged and will be available in a release soon.

@Joffcom Joffcom merged commit 6b9909b into n8n-io:master Apr 17, 2023
@eddywashere eddywashere deleted the patch-1 branch April 17, 2023 15:57
MiloradFilipovic added a commit that referenced this pull request Apr 18, 2023
* master: (30 commits)
  feat(core): Add versionControl feature flag (#6000)
  fix: Small changes to user activation modal (no-changelog) (#5962)
  fix(editor): Cleanup demo/video experiment (#5974)
  feat: Add variables feature (#5602)
  ci: Improve test for wait node (#5997)
  fix(editor): Fix moving canvas on middle click preventing lasso selection (#5996)
  fix(HTTP Request Node): Fix itemIndex in HTTP Request errors (#5991)
  refactor(editor): Refactor history and debounce mixins to composables (no-changelog) (#5930)
  feat(GitLab Node): Add Additional parameters for File List (#5621)
  build: Update license SDK to v2.1.0 (no-changelog) (#5987)
  fix(OpenAI Node): Update OpenAI Text Moderate input placeholder text (#5823)
  fix(Code Node): Handle user code returning `null` and `undefined` (#5989)
  fix(Google Sheets Trigger Node): Return actual error message
  fix(core): Make `getExecutionId` available on all nodes types (#5990)
  ci: Add checklist item hinting at not adding new dependencies for nodes (no-changelog) (#5985)
  fix(core): Improve SAML connection test result views (#5981)
  fix(IF Node): Fix typo in combine description (no-changelog) (#5964)
  ci: Add a workflow to push n8n releases to release channels (no-changelog) (#5839)
  fix(editor): Make sure to redirect to blank canvas after personalisation modal (#5980)
  fix(core): Fix paired item returning wrong data (#5898)
  ...

# Conflicts:
#	packages/editor-ui/src/Interface.ts
MiloradFilipovic added a commit that referenced this pull request Apr 18, 2023
…rce-mapper-ui

* feature/resource-mapping-component: (30 commits)
  feat(core): Add versionControl feature flag (#6000)
  fix: Small changes to user activation modal (no-changelog) (#5962)
  fix(editor): Cleanup demo/video experiment (#5974)
  feat: Add variables feature (#5602)
  ci: Improve test for wait node (#5997)
  fix(editor): Fix moving canvas on middle click preventing lasso selection (#5996)
  fix(HTTP Request Node): Fix itemIndex in HTTP Request errors (#5991)
  refactor(editor): Refactor history and debounce mixins to composables (no-changelog) (#5930)
  feat(GitLab Node): Add Additional parameters for File List (#5621)
  build: Update license SDK to v2.1.0 (no-changelog) (#5987)
  fix(OpenAI Node): Update OpenAI Text Moderate input placeholder text (#5823)
  fix(Code Node): Handle user code returning `null` and `undefined` (#5989)
  fix(Google Sheets Trigger Node): Return actual error message
  fix(core): Make `getExecutionId` available on all nodes types (#5990)
  ci: Add checklist item hinting at not adding new dependencies for nodes (no-changelog) (#5985)
  fix(core): Improve SAML connection test result views (#5981)
  fix(IF Node): Fix typo in combine description (no-changelog) (#5964)
  ci: Add a workflow to push n8n releases to release channels (no-changelog) (#5839)
  fix(editor): Make sure to redirect to blank canvas after personalisation modal (#5980)
  fix(core): Fix paired item returning wrong data (#5898)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member node/improvement New feature or request skip-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants