Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Initialize queue in the webhook server as well #5766

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

netroy
Copy link
Member

@netroy netroy commented Mar 23, 2023

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

@netroy netroy changed the title fix(core): Initialize queue in the webhook server as well (no-changelog) fix(core): Initialize queue in the webhook server as well Mar 23, 2023
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Mar 23, 2023
@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (d78a41d) 14.50% compared to head (76c7e3a) 14.49%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5766      +/-   ##
==========================================
- Coverage   14.50%   14.49%   -0.01%     
==========================================
  Files        2473     2473              
  Lines      113261   113263       +2     
  Branches    17644    17643       -1     
==========================================
- Hits        16426    16423       -3     
- Misses      96316    96321       +5     
  Partials      519      519              
Impacted Files Coverage Δ
packages/cli/src/commands/webhook.ts 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@netroy netroy merged commit e67ad29 into master Mar 24, 2023
@netroy netroy deleted the fix-webhooks branch March 24, 2023 09:47
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Mar 24, 2023
@janober
Copy link
Member

janober commented Mar 30, 2023

Got released with [email protected]

sunilrr pushed a commit to fl-g6/qp-n8n that referenced this pull request Apr 24, 2023
fix(core): Initialize queue in the webhook server as well (no-changelog)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released skip-e2e Upcoming Release Will be part of the upcoming release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants