Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Fix the canvas node distance when automatically injecting manual trigger #5716

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

OlegIvaniv
Copy link
Contributor

@OlegIvaniv OlegIvaniv commented Mar 17, 2023

The distance between auto-injected manual trigger and the node should be same as when we add a connected node via the "+" button. For this we need to add the GRID_SIZE constant to the position calculation.

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching **/*.vue:

  • Used composition API for all new components.
  • Added component or unit tests to cover functionality.

Files matching packages/editor-ui/**/*.vue:

  • Added E2E if adding new features.
  • Used design system tokens (colors, spacings...) where possible.

Files matching packages/editor-ui/src/views/NodeView.vue:

  • Avoided adding code here. Only refactored to make it smaller.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Mar 17, 2023
@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f59b591) 13.23% compared to head (e0197a3) 13.23%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5716   +/-   ##
=======================================
  Coverage   13.23%   13.23%           
=======================================
  Files        2463     2463           
  Lines      112805   112805           
  Branches    17542    17542           
=======================================
  Hits        14926    14926           
  Misses      97373    97373           
  Partials      506      506           
Impacted Files Coverage Δ
packages/cli/src/InternalHooks.ts 6.38% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@MiloradFilipovic MiloradFilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as expected.

@MiloradFilipovic MiloradFilipovic self-requested a review March 17, 2023 13:09
@OlegIvaniv OlegIvaniv merged commit cb2ba97 into master Mar 20, 2023
@OlegIvaniv OlegIvaniv deleted the fix_auto_inject_distance_manual_trigger branch March 20, 2023 10:11
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Mar 20, 2023
@janober
Copy link
Member

janober commented Mar 26, 2023

Got released with [email protected]

@janober
Copy link
Member

janober commented Mar 26, 2023

Got released with [email protected]

sunilrr pushed a commit to fl-g6/qp-n8n that referenced this pull request Apr 24, 2023
…g manual trigger (n8n-io#5716)

fix(editor): Fix the canvas node distance when automatically adding manual trigger
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system Upcoming Release Will be part of the upcoming release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants