-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(editor): Fix the canvas node distance when automatically injecting manual trigger #5716
Conversation
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Files matching
Files matching
Make sure to check off this list before asking for review. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #5716 +/- ##
=======================================
Coverage 13.23% 13.23%
=======================================
Files 2463 2463
Lines 112805 112805
Branches 17542 17542
=======================================
Hits 14926 14926
Misses 97373 97373
Partials 506 506
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and works as expected.
Got released with |
Got released with |
…g manual trigger (n8n-io#5716) fix(editor): Fix the canvas node distance when automatically adding manual trigger
The distance between auto-injected manual trigger and the node should be same as when we add a connected node via the "+" button. For this we need to add the
GRID_SIZE
constant to the position calculation.