feat(core): Refactor and add SAML preferences for service provider instance #5637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
RicardoE105
approved these changes
Mar 8, 2023
| throw new BadRequestError(`Error fetching SAML Metadata from ${this.metadataUrl}: ${error}`); | ||
| throw new BadRequestError( | ||
| // eslint-disable-next-line @typescript-eslint/restrict-template-expressions | ||
| `Error fetching SAML Metadata from ${this._samlPreferences.metadataUrl}: ${error}`, |
There was a problem hiding this comment.
Do we need the whole error here? Can't we use only the message?
There was a problem hiding this comment.
The error may contain more context which could be useful.
flipswitchingmonkey
deleted the
pay-279-switch-saml-sp-from-raw-metadata-to
branch
MiloradFilipovic
added a commit
that referenced
this pull request
Mar 10, 2023
* master: (358 commits) refactor: Remove n8n-core dependency in nodes-base (no-changelog) (#5649) 🚀 Release 0.219.0 (#5659) fix(core): Fix trying to pipe a non stream on errors (no-changelog) (#5660) ci: Fix e2e tests (no-changelog) (#5658) fix(core): Fix issues with LDAP reset and LDAP init (no-changelog) (#5657) feat(HTTP Request Node): Move from Binary Buffer to Binary streaming (#5610) feat(editor): Only redirect new users to blank canvas (no-changelog) (#5654) feat(editor): Do not automatically add manual trigger on node plus (#5644) feat(core): Allow using middlewares with decorators on a per-route basis (no-changelog) (#5656) refactor(core): Convert more routes to use the decorator pattern (no-changelog) (#5611) fix: Fetch credentials on workflows view to include in duplicated workflows (#5532) ci: Add PR checklist (#5628) feat(Mindee Node): Add support for v4 API (#5559) feat(Microsoft SQL Node): Add support for self signed certificates (#5160) fix(editor): Only fetch new versions at app launch (#5647) fix(core): Use new version of riot-tmpl in workflow package (no-changelog) (#5619) feat(core): Refactor and add SAML preferences for service provider instance (#5637) docs(Github Trigger Node): Add notice and more meaningful error around permissions (#5551) feat(Cal Trigger Node): Update to support v2 webhooks (#5331) feat(editor): Redirect users to canvas if they don't have any workflows (#5629) ...
|
Got released with |
sunilrr
pushed a commit
to fl-g6/qp-n8n
that referenced
this pull request
Apr 24, 2023
…stance (n8n-io#5637) * create SP through parameters instead of metadata * refactor SAML prefs and add SP configurations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github issue / Community forum post (link here to close automatically):