feat: Add basic variables support #5602

valya · 2023-03-02T17:51:03Z

Github issue / Community forum post (link here to close automatically):

github-actions · 2023-03-13T15:57:07Z

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

If fixing bug, added test to cover scenario.
If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

Added unit tests to cover new or updated functionality.

Files matching packages/cli/src/databases/migrations/**:

Requested review from at least two engineers on migration.
Avoided irreversible data migrations.
Avoided deleting or updating data keys.
Wrote 'down' migration if possible.

Make sure to check off this list before asking for review.

codecov · 2023-03-14T15:34:32Z

Codecov Report

Patch coverage: 63.86% and project coverage change: +0.50 🎉

Comparison is base (ee7d5a8) 18.00% compared to head (fc2d69d) 18.50%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5602      +/-   ##
==========================================
+ Coverage   18.00%   18.50%   +0.50%     
==========================================
  Files        2539     2562      +23     
  Lines      115306   116028     +722     
  Branches    17989    18119     +130     
==========================================
+ Hits        20757    21472     +715     
- Misses      93921    93926       +5     
- Partials      628      630       +2

Impacted Files	Coverage Δ
packages/cli/src/InternalHooks.ts	`6.70% <0.00%> (-0.07%)`	⬇️
packages/cli/src/Server.ts	`0.00% <0.00%> (ø)`
packages/cli/src/requests.ts	`100.00% <ø> (ø)`
packages/core/src/NodeExecuteFunctions.ts	`14.59% <ø> (ø)`
...n-system/src/components/N8nFormInput/validators.ts	`0.00% <0.00%> (ø)`
...ackages/design-system/src/plugins/n8nComponents.ts	`0.00% <0.00%> (ø)`
packages/design-system/src/types/datatable.ts	`0.00% <0.00%> (ø)`
packages/design-system/src/types/form.ts	`0.00% <0.00%> (ø)`
packages/design-system/src/types/index.ts	`0.00% <0.00%> (ø)`
...nts/CodeNodeEditor/completions/base.completions.ts	`18.40% <0.00%> (-0.47%)`	⬇️
... and 39 more

... and 27 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

…-230-p0-variables

packages/cli/src/License.ts

packages/cli/src/databases/migrations/mysqldb/1677501636753-CreateVariables.ts

packages/cli/src/databases/migrations/postgresdb/1677501636754-CreateVariables.ts

packages/cli/src/environments/variables.controller.ts

packages/cli/src/environments/variables.service.ts

packages/cli/test/integration/variables.test.ts

packages/core/src/NodeExecuteFunctions.ts

* feat: add support for row slot to datatable * feat: add variables create, read, update, delete * feat: add vars autocomplete * chore: remove alert * feat: add variables autocomplete for code and expressions * feat: add tests for variable components * feat: add variables search and sort * test: update tests for variables view * chore: fix test and linting issue

…g (no-changelog) (#5903) * fix: Improve variables disabled experience and fix sorting * fix: update action box margin * test: update tests for variables row and datatable

…-230-p0-variables

…5910) * feat: add input validation * feat: handle variables view for non-instance-owner users * test: update variables tests * fix: fix data-testid pattern * feat: improve overflow styles * test: fix variables row snapshot * feat: update sorting to take newly created variables into account * fix: fix list layout overflow * fix: fix adding variables on page other than 1. fix validation * feat: add docs link * fix: fix default displayName function for resource-list-layout * feat: improve vars expressions ux, cm-tooltip * test: fix datatable test * feat: add MATCH_REGEX validation rule * fix: overhaul how datatable pagination selector works * feat: update completer description * fix: conditionally update usage syntax based on key validation * test: update datatable snapshot * fix: fix variables-row button margins * fix: fix pagination overflow

github-actions · 2023-04-14T13:20:26Z

✅ All Cypress E2E specs passed

github-actions · 2023-04-14T14:23:37Z

✅ All Cypress E2E specs passed

github-actions · 2023-04-18T10:22:04Z

✅ All Cypress E2E specs passed

* master: (30 commits) feat(core): Add versionControl feature flag (#6000) fix: Small changes to user activation modal (no-changelog) (#5962) fix(editor): Cleanup demo/video experiment (#5974) feat: Add variables feature (#5602) ci: Improve test for wait node (#5997) fix(editor): Fix moving canvas on middle click preventing lasso selection (#5996) fix(HTTP Request Node): Fix itemIndex in HTTP Request errors (#5991) refactor(editor): Refactor history and debounce mixins to composables (no-changelog) (#5930) feat(GitLab Node): Add Additional parameters for File List (#5621) build: Update license SDK to v2.1.0 (no-changelog) (#5987) fix(OpenAI Node): Update OpenAI Text Moderate input placeholder text (#5823) fix(Code Node): Handle user code returning `null` and `undefined` (#5989) fix(Google Sheets Trigger Node): Return actual error message fix(core): Make `getExecutionId` available on all nodes types (#5990) ci: Add checklist item hinting at not adding new dependencies for nodes (no-changelog) (#5985) fix(core): Improve SAML connection test result views (#5981) fix(IF Node): Fix typo in combine description (no-changelog) (#5964) ci: Add a workflow to push n8n releases to release channels (no-changelog) (#5839) fix(editor): Make sure to redirect to blank canvas after personalisation modal (#5980) fix(core): Fix paired item returning wrong data (#5898) ... # Conflicts: # packages/editor-ui/src/Interface.ts

…rce-mapper-ui * feature/resource-mapping-component: (30 commits) feat(core): Add versionControl feature flag (#6000) fix: Small changes to user activation modal (no-changelog) (#5962) fix(editor): Cleanup demo/video experiment (#5974) feat: Add variables feature (#5602) ci: Improve test for wait node (#5997) fix(editor): Fix moving canvas on middle click preventing lasso selection (#5996) fix(HTTP Request Node): Fix itemIndex in HTTP Request errors (#5991) refactor(editor): Refactor history and debounce mixins to composables (no-changelog) (#5930) feat(GitLab Node): Add Additional parameters for File List (#5621) build: Update license SDK to v2.1.0 (no-changelog) (#5987) fix(OpenAI Node): Update OpenAI Text Moderate input placeholder text (#5823) fix(Code Node): Handle user code returning `null` and `undefined` (#5989) fix(Google Sheets Trigger Node): Return actual error message fix(core): Make `getExecutionId` available on all nodes types (#5990) ci: Add checklist item hinting at not adding new dependencies for nodes (no-changelog) (#5985) fix(core): Improve SAML connection test result views (#5981) fix(IF Node): Fix typo in combine description (no-changelog) (#5964) ci: Add a workflow to push n8n releases to release channels (no-changelog) (#5839) fix(editor): Make sure to redirect to blank canvas after personalisation modal (#5980) fix(core): Fix paired item returning wrong data (#5898) ...

netroy · 2023-03-16T12:56:53Z

packages/cli/test/integration/variables.test.ts

+
+import type { AuthAgent } from './shared/types';
+
+// mock that credentialsSharing is not enabled


is this a copy-paste comment? there is no code testing credentialsSharing here.

netroy · 2023-04-19T09:56:29Z

packages/cli/src/databases/migrations/postgresdb/1677501636754-CreateVariables.ts

+		const tablePrefix = getTablePrefix();
+
+		await queryRunner.query(`
+			CREATE TABLE public.variables (


This should be CREATE TABLE ${tablePrefix}variables.

Fixed here #6011

github-actions · 2023-04-19T09:57:21Z

✅ All Cypress E2E specs passed

* feat: add variables db models and migrations * feat: variables api endpoints * feat: add $variables to expressions * test: fix ActiveWorkflowRunner tests failing * test: a different fix for the tests broken by $variables * feat: variables licensing * fix: could create one extra variable than licensed for * feat: Add Variables UI page and $vars global property (n8n-io#5750) * feat: add support for row slot to datatable * feat: add variables create, read, update, delete * feat: add vars autocomplete * chore: remove alert * feat: add variables autocomplete for code and expressions * feat: add tests for variable components * feat: add variables search and sort * test: update tests for variables view * chore: fix test and linting issue * refactor: review changes * feat: add variable creation telemetry * fix: Improve variables listing and disabled case, fix resource sorting (no-changelog) (n8n-io#5903) * fix: Improve variables disabled experience and fix sorting * fix: update action box margin * test: update tests for variables row and datatable * fix: Add ee controller to base controller * fix: variables.ee routes not being added * feat: add variables validation * fix: fix vue-fragment bug that breaks everything * chore: Update lock * feat: Add variables input validation and permissions (no-changelog) (n8n-io#5910) * feat: add input validation * feat: handle variables view for non-instance-owner users * test: update variables tests * fix: fix data-testid pattern * feat: improve overflow styles * test: fix variables row snapshot * feat: update sorting to take newly created variables into account * fix: fix list layout overflow * fix: fix adding variables on page other than 1. fix validation * feat: add docs link * fix: fix default displayName function for resource-list-layout * feat: improve vars expressions ux, cm-tooltip * test: fix datatable test * feat: add MATCH_REGEX validation rule * fix: overhaul how datatable pagination selector works * feat: update completer description * fix: conditionally update usage syntax based on key validation * test: update datatable snapshot * fix: fix variables-row button margins * fix: fix pagination overflow * test: Fix broken test * test: Update snapshot * fix: Remove duplicate declaration * feat: add custom variables icon --------- Co-authored-by: Alex Grozav <[email protected]> Co-authored-by: Omar Ajoue <[email protected]>

valya added 5 commits February 28, 2023 13:54

feat: add variables db models and migrations

48ef2a4

Merge remote-tracking branch 'origin/master' into pay-230-p0-variables

80a0250

Merge remote-tracking branch 'origin/master' into pay-230-p0-variables

c81c1ae

feat: variables api endpoints

1eb521a

feat: add $variables to expressions

af4ffcb

n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team node/improvement New feature or request labels Mar 2, 2023

valya marked this pull request as ready for review March 3, 2023 14:26

valya added 2 commits March 13, 2023 15:16

test: fix ActiveWorkflowRunner tests failing

26b58dc

Merge remote-tracking branch 'origin/master' into pay-230-p0-variables

050ac9b

valya requested a review from a team as a code owner March 13, 2023 15:56

test: a different fix for the tests broken by $variables

3f94ea6

alexgrozav and others added 6 commits March 15, 2023 11:55

Merge branch 'master' into pay-230-p0-variables

92563b5

feat: variables licensing

edf6a00

Merge branch 'pay-230-p0-variables' of github.com:n8n-io/n8n into pay…

67fff50

…-230-p0-variables

Merge branch 'master' into pay-230-p0-variables

c0d58bf

fix: could create one extra variable than licensed for

99c8778

Merge branch 'pay-230-p0-variables' of github.com:n8n-io/n8n into pay…

83a3bec

…-230-p0-variables

krynble suggested changes Mar 23, 2023

View reviewed changes

alexgrozav and others added 5 commits March 28, 2023 10:44

Merge remote-tracking branch 'origin/master' into pay-230-p0-variables

3982960

Merge remote-tracking branch 'origin/master' into pay-230-p0-variables

a16a45f

refactor: review changes

afd8905

feat: add variable creation telemetry

4aadc91

valya force-pushed the pay-230-p0-variables branch from fb56535 to 4aadc91 Compare April 4, 2023 12:37

alexgrozav and others added 2 commits April 4, 2023 16:56

fix: Improve variables listing and disabled case, fix resource sortin…

dae6e21

…g (no-changelog) (#5903) * fix: Improve variables disabled experience and fix sorting * fix: update action box margin * test: update tests for variables row and datatable

fix: Add ee controller to base controller

5d5bb63

valya and others added 10 commits April 5, 2023 12:08

fix: variables.ee routes not being added

ecceef4

Merge branch 'pay-230-p0-variables' of github.com:n8n-io/n8n into pay…

44c9055

…-230-p0-variables

feat: add variables validation

54a502b

fix: fix vue-fragment bug that breaks everything

2011c4d

Merge branch 'pay-230-p0-variables' of github.com:n8n-io/n8n into pay…

0893efb

…-230-p0-variables

chore: Merge master

f8af500

chore: Update lock

0688680

chore: merge master

a494268

chore: merge master

64d5199

krynble previously approved these changes Apr 14, 2023

View reviewed changes

test: Fix broken test

75df184

krynble dismissed their stale review via 75df184 April 14, 2023 13:19

krynble added 2 commits April 14, 2023 15:42

test: Update snapshot

f281b55

fix: Remove duplicate declaration

a27e00d

krynble previously approved these changes Apr 14, 2023

View reviewed changes

feat: add custom variables icon

fc2d69d

alexgrozav dismissed krynble’s stale review via fc2d69d April 18, 2023 10:06

krynble approved these changes Apr 18, 2023

View reviewed changes

krynble merged commit 1bb9871 into master Apr 18, 2023

krynble deleted the pay-230-p0-variables branch April 18, 2023 10:41

netroy reviewed Apr 19, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add basic variables support #5602

feat: Add basic variables support #5602

valya commented Mar 2, 2023

github-actions bot commented Mar 13, 2023 •

edited

Loading

codecov bot commented Mar 14, 2023 •

edited

Loading

github-actions bot commented Apr 14, 2023

github-actions bot commented Apr 14, 2023

github-actions bot commented Apr 18, 2023

netroy Mar 16, 2023

netroy Apr 19, 2023

github-actions bot commented Apr 19, 2023


		import type { AuthAgent } from './shared/types';

		// mock that credentialsSharing is not enabled

feat: Add basic variables support #5602

feat: Add basic variables support #5602

Conversation

valya commented Mar 2, 2023

github-actions bot commented Mar 13, 2023 • edited Loading

codecov bot commented Mar 14, 2023 • edited Loading

Codecov Report

github-actions bot commented Apr 14, 2023

github-actions bot commented Apr 14, 2023

github-actions bot commented Apr 18, 2023

netroy Mar 16, 2023

Choose a reason for hiding this comment

netroy Apr 19, 2023

Choose a reason for hiding this comment

github-actions bot commented Apr 19, 2023

github-actions bot commented Mar 13, 2023 •

edited

Loading

codecov bot commented Mar 14, 2023 •

edited

Loading