Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pasting doesn't allow the undo functionality in expression fields or code nodes at first. #5297

Closed
mprytoluk opened this issue Jan 30, 2023 · 1 comment · Fixed by #8178
Closed
Labels
in linear Issue or PR has been created in Linear for internal review

Comments

@mprytoluk
Copy link
Contributor

Describe the bug
If the first interaction with any expression field on any node, or the main field on a Code node (i.e. any field that accepts javascript) is a "Ctrl + V" (or right click -> Paste), this doesn't seem to trigger the "Undo" functionality, meaning you can't "Ctrl + Z" if your first action in one of those field is a "Ctrl + V".

If directly after a "Ctrl+V" you write anything, you can now Undo your previous actions, even the paste action.

To Reproduce
Steps to reproduce the behavior:

  1. Open a "Code" node or an "Expression" field in any node.
  2. Immediately past something, without writing anything before
  3. Try to Undo
  4. Undo action is not available
  5. Write anything
  6. Undo action is available!

Expected behavior
Undo action should be available even if pasting is your first action in said nodes

Environment (please complete the following information):

  • Ubuntu Linux 22.04
  • n8n Version 0.212.1

Additional context
This bug doesn't seem to happen on the old Function and FunctionItem nodes.

@Joffcom
Copy link
Member

Joffcom commented Jan 31, 2023

Hey @miguel-mconf,

Thanks for reporting this one, I have created an internal ticket which we are tracking as N8N-6082.

@Joffcom Joffcom added the in linear Issue or PR has been created in Linear for internal review label Jan 31, 2023
netroy added a commit that referenced this issue Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in linear Issue or PR has been created in Linear for internal review
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants