Broken DeleteExecutionsWithWorkflows migration

[ifokeev]

Bug not fixed, so reopen the issue.
Same situation as described in #5183 while migrating to 0.212.0 from 0.210.0.

After checking the codebase, it looks like DB_POSTGRESDB_SCHEMA

n8n/packages/cli/src/config/schema.ts

Line 100 in 9b032d6

env: 'DB_POSTGRESDB_SCHEMA',

is not used anymore?

I'm using a specified schema for n8n, but I don't see that migrations are executed in this scope.

All new migrations are not specifying the schema as here:

n8n/packages/cli/src/databases/migrations/postgresdb/1658932090381-AddNodeIds.ts

Lines 13 to 16 in 0da338f

	const schema = config.getEnv('database.postgresdb.schema');
	if (schema) {
	tablePrefix = schema + '.' + tablePrefix;
	}

For example:
https://github.com/n8n-io/n8n/blob/master/packages/cli/src/databases/migrations/postgresdb/1673268682475-DeleteExecutionsWithWorkflows.ts

I see there is a function getTablePrefix, but it's not used everywhere:

n8n/packages/cli/src/databases/migrations/postgresdb/1669823906995-AddTriggerCountColumn.ts

Line 11 in 0da338f

const tablePrefix = getTablePrefix();

It looks like all new migrations should use this function

Environment:

• n8n Version 0.210.0

[Joffcom]

Hey @ifokeev

Thanks for reporting this one, will get a fix in place shortly for the next release.

[krynble]

We plan on releasing a hotfix today, the fix can be seen here: #5218

[ifokeev]

Hi @krynble!
Thanks for the fix, but the same code

 const tablePrefix = getTablePrefix(); 

should be in every migration, not only in this one

[krynble]

Good point @ifokeev, added the others too.

[janober]

Fix got released with [email protected]

[Joffcom]

Hey @ifokeev,

As this is resolved I am going to close this issue, We will also be updating all of the older migrations to use the newer approach to keep things consistent.

Thanks again for reporting this.