Broken DeleteExecutionsWithWorkflows migration

[terenaa]

Describe the bug
Migration collects workflow execution IDs instead of workflow IDs preparing to create FK.

const workflowIds: Array<{ id: number }> = await queryRunner.query(`
  SELECT id FROM \`${tablePrefix}execution_entity\`
`);

await queryRunner.query(
  `DELETE FROM \`${tablePrefix}execution_entity\`
  WHERE workflowId IS NOT NULL
  ${workflowIds.length ? `AND workflowId NOT IN (${workflowIds.map(({ id }) => id).join()})` : ''}`,
);

Field id from execution_entity has no relation with workflowId.

To Reproduce
Steps to reproduce the behavior:

1. Create an entry in execution_entity with workflowId which does not exist in workflow_entity.
2. ALTER TABLE ... will fail.

Expected behavior
Variable workflowIds should contain ids from workflow_entity table.

Environment:

• n8n Version 0.211.0

[Joffcom]

Hey @terenaa,

Thanks for reporting this one and a great spot, It looks like @csuermann has popped in a fix already which should make it into the next release.

[janober]

Fix got released with [email protected]

[ifokeev]

Still not working, version 0.212.0, migration from 0.210.0