feat(LoneScale Node): Add LoneScale node and Trigger node

[SanYann]

Github issue / Community forum post (link here to close automatically):

[CLAassistant]

All committers have signed the CLA.

[Joffcom]

Hey @SanYann,

I was just starting to review this and I got part of the way through it and I was wondering if this was finished or still a work in progress?

[SanYann]

Hey @SanYann,

I was just starting to review this and I got part of the way through it and I was wondering if this was finished or still a work in progress?

Hello, It is finished and tested locally

[Joffcom]

Hey @SanYann,

Perfect, I had to double check as there were some things that were a bit odd. It looks like the linter is still showing some errors and there is no support for continueOnFail. I have added in a credential test and moved all of the requests to use the same function.

When I was looking at the UI I noticed that adding a company and a contact uses the same fields, Is that expected? Looking at the API docs there might not be a first name field for company. Do you know if there is a way to get hold of test credentials or would signing up for a trial be the best bet?

[SanYann]

Hey @SanYann,

Perfect, I had to double check as there were some things that were a bit odd. It looks like the linter is still showing some errors and there is no support for continueOnFail. I have added in a credential test and moved all of the requests to use the same function.

When I was looking at the UI I noticed that adding a company and a contact uses the same fields, Is that expected? Looking at the API docs there might not be a first name field for company. Do you know if there is a way to get hold of test credentials or would signing up for a trial be the best bet?

Hello,

Thanks a lot for your improvements.
Company and People uses the same fields for now, you can for exemple create a people attached to a company.
To test credentials, I can create a test account with default password on your email address, you will just have to create a new one on your first connection

[Joffcom]

Hey @SanYann,

That could work, There is still a bit more tidying up to do and support for features like continue on fail and paired items but I think another couple of sessions and it should be in a good place.

[SanYann]

continueOnFail

Do you have documentation I could follow or example to implement continue on fail and paired items?

[Joffcom]

Hey @SanYann,

PairedItems can be found here: https://docs.n8n.io/integrations/creating-nodes/build/reference/paired-items/

ContinueOnFail I can't see anything for but most nodes will have it at the bottom of the item loop, It will look something like this...

const executionData = this.helpers.constructExecutionMetaData(
					this.helpers.returnJsonArray(responseData),
					{ itemData: { item: i } },
				);
				returnData.push(...executionData);
			} catch (error) {
				if (this.continueOnFail()) {
					returnData.push({ error: error.message, json: {} });
					continue;
				}
				throw error;
			}
		}

If you use the newer declarative style this sort of thing is taken care of for you as well and it normally means you can build out a node fairly quickly as you don't need to worry about some of the more standard things but both styles are valid.

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (4219490) 27.69% compared to head (c3d6cf5) 27.67%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5146      +/-   ##
==========================================
- Coverage   27.69%   27.67%   -0.02%     
==========================================
  Files        2947     2952       +5     
  Lines      180861   180986     +125     
  Branches    19634    19660      +26     
==========================================
  Hits        50090    50090              
- Misses     130026   130151     +125     
  Partials      745      745              

Impacted Files	Coverage Δ
...nodes-base/credentials/LoneScaleApi.credentials.ts	0.00% <0.00%> (ø)
...ges/nodes-base/nodes/LoneScale/GenericFunctions.ts	0.00% <0.00%> (ø)
...s/nodes-base/nodes/LoneScale/LoneScaleList.node.ts	0.00% <0.00%> (ø)
...odes-base/nodes/LoneScale/LoneScaleTrigger.node.ts	0.00% <0.00%> (ø)
packages/nodes-base/nodes/LoneScale/constants.ts	0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[janober]

Got released with [email protected]