feat(editor): Introduce proxy completions to expressions #5075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
cstuncsik
previously approved these changes
Jan 4, 2023
ivov
commented
Jan 4, 2023
| @@ -69,6 +69,357 @@ import { ICredentialsResponse } from '@/Interface'; | |||
| let cachedWorkflowKey: string | null = ''; | |||
| let cachedWorkflow: Workflow | null = null; | |||
|
|
|||
| export function resolveParameter( | |||
There was a problem hiding this comment.
Changes here are moving resolution functions out of the mixin so they can be called during completion.
cstuncsik
approved these changes
Jan 6, 2023
MiloradFilipovic
added a commit
that referenced
this pull request
Jan 9, 2023
* master: (53 commits) fix: Remove anonymous ID from tracking calls (#5099) refactor(core): Add more overloads for string-type node parameters (no-changelog) (#5101) fix(Read Binary File Node): Do not crash the execution when the source file does not exist (#5100) fix: Stop OOM crashes in Execution Data pruning (#5095) feat(editor): Introduce proxy completions to expressions (#5075) fix(Google Sheets Node): Fix for auto-range detection 📚 Update CHANGELOG.md and main package.json to 0.210.1 🔖 Release [email protected] ⬆️ Set [email protected] and [email protected] on n8n 🔖 Release [email protected] ⬆️ Set [email protected] on n8n-editor-ui 🔖 Release [email protected] 🔖 Release [email protected] fix: Pass in the correct server reference to external hooks (no-changelog) (#5094) fix(Google Sheets Node): Append or Update fails for numeric values feat: Add user management invite links without SMTP set up (#5084) fix: Remove annonymous ID (no-changelog) (#5093) 📚 Update CHANGELOG.md and main package.json to 0.210.0 🔖 Release [email protected] ⬆️ Set [email protected], [email protected], [email protected] and [email protected] on n8n ... # Conflicts: # packages/editor-ui/src/components/CredentialEdit/CredentialEdit.vue
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story: https://linear.app/n8n/issue/ADO-109/expression-editor-auto-complete