Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Split In Batches Node): Fix issue with pairedItem #4873

Merged
merged 1 commit into from
Dec 9, 2022
Merged

fix(Split In Batches Node): Fix issue with pairedItem #4873

merged 1 commit into from
Dec 9, 2022

Conversation

janober
Copy link
Member

@janober janober commented Dec 9, 2022

Fixes the pairedItem issue in combination with the Split in Batches node if data outside of the loop does get accessed.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team node/improvement New feature or request labels Dec 9, 2022
@netroy netroy changed the title fix(SplitInBatches Node): Fix issue with pairedItem fix(Split In Batches Node): Fix issue with pairedItem Dec 9, 2022
agobrech
agobrech approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@agobrech agobrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, is it the only node that would benefit from this fix?

@janober
Copy link
Member Author

janober commented Dec 9, 2022

Exactly. It is the only node that messes up the "history" and needs so an overwrite.

@janober janober merged commit 38d7300 into master Dec 9, 2022
@janober janober deleted the paireditem-splitinbatches-fix branch December 9, 2022 12:39
@janober janober added the Upcoming Release Will be part of the upcoming release label Dec 9, 2022
@janober
Copy link
Member Author

janober commented Dec 9, 2022

Thanks a lot for the review. Got merged.

MiloradFilipovic added a commit that referenced this pull request Dec 12, 2022
@MiloradFilipovic
Merge branch 'master' into ADO-32-e2e-undo
692e8c4 
* master:
  fix(editor): Avoid adding manual trigger node when webhook node is added (#4887)
  ci: Add libc6-compat to nightly docker builds (no-changelog) (#4885)
  fix(Move Binary Data Node): Stringify objects before encoding them in MoveBinaryData (#4882)
  ci: Upgrade pnpm and turborepo (no-changelog) (#4878)
  fix(editor): Fix for broken tab navigation (#4881)
  feat(editor): Add undo/redo support for canvas actions (#4787)
  fix(Split In Batches Node): Fix issue with pairedItem (#4873)
  fix: Update duplicate action (#4858)

# Conflicts:
#	packages/editor-ui/src/Interface.ts
#	packages/editor-ui/src/mixins/history.ts
#	packages/editor-ui/src/views/NodeView.vue
@janober
Copy link
Member Author

janober commented Dec 12, 2022

Got released with [email protected]

@janober janober removed the Upcoming Release Will be part of the upcoming release label Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agobrech agobrech agobrech approved these changes

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team node/improvement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janober @agobrech