Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): Add MFA #4767

Merged
merged 200 commits into from
Aug 24, 2023
Merged

feat(core): Add MFA #4767

merged 200 commits into from
Aug 24, 2023

Conversation

RicardoE105
Copy link
Contributor

@RicardoE105 RicardoE105 commented Nov 29, 2022 •
edited by janober
Loading

@RicardoE105 RicardoE105 changed the title ⚡ MFA initial setup feat(cli): Add MFA Nov 29, 2022
@RicardoE105 RicardoE105 changed the title feat(cli): Add MFA feat(core): Add MFA Nov 29, 2022
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Nov 29, 2022
@RicardoE105 RicardoE105 marked this pull request as draft February 2, 2023 21:50
@krynble
Copy link
Contributor

krynble commented Aug 22, 2023

@krynble with text seems to be working on the 3 databases!

Have you tried with a fresh database, creating the tables from scratch? If I use an existing database (that was already migrated with varchar) then it starts, but also won't work.

I'm using MySQL version 8.0.32 here, if that helps.

@RicardoE105 RicardoE105 requested a review from mutdmour August 22, 2023 13:30
@github-actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@cypress
Copy link

cypress bot commented Aug 23, 2023 •
edited
Loading

Passing run #1979 ↗︎

0 231 0 0 Flakiness 0

Details:

🌳 ado-21-sync-current-mfa-functionality-with 🖥️ browsers:node18.12.0-chrome107...
Project: n8n Commit: b7818fe01d
Status: Passed Duration: 00:24 💡
Started: Aug 23, 2023 11:41 PM Ended: Aug 24, 2023 12:41 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

krynble
krynble previously approved these changes Aug 23, 2023
View reviewed changes
@github-actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

OlegIvaniv
OlegIvaniv previously approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@OlegIvaniv OlegIvaniv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving to trigger e2es

mutdmour
mutdmour previously approved these changes Aug 23, 2023
View reviewed changes
@github-actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

1 similar comment
@github-actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@RicardoE105 RicardoE105 dismissed stale reviews from mutdmour, OlegIvaniv, and krynble via b7818fe August 23, 2023 15:36
@github-actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@RicardoE105 RicardoE105 removed the request for review from netroy August 23, 2023 23:40
@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@RicardoE105 RicardoE105 merged commit 2b7ba6f into master Aug 24, 2023
@RicardoE105 RicardoE105 deleted the ado-21-sync-current-mfa-functionality-with branch August 24, 2023 02:59
netroy
netroy reviewed Aug 24, 2023
View reviewed changes
packages/cli/src/databases/migrations/common/1690000000040-AddMfaColumns.ts

export class AddMfaColumns1690000000030 implements ReversibleMigration {
async up({ queryRunner, tablePrefix }: MigrationContext) {
await queryRunner.addColumns(`${tablePrefix}user`, [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding removing columns like causes data-loss because of a typeorm issue. Fix here.

@github-actions github-actions bot mentioned this pull request Aug 31, 2023
Merged
netroy added a commit that referenced this pull request Aug 31, 2023
@github-actions @netroy
🚀 Release 1.5.0 (#7056)
0ca2c78 
# [1.5.0](https://github.com/n8n-io/n8n/compare/[email protected]@1.5.0)
(2023-08-31)


### Bug Fixes

* **Agile CRM Node:** Fix issue with company address not working
([#6997](#6997))
([2f81652](2f81652))
* **Code Node:** Switch over to vm2 fork
([#7018](#7018))
([dfe0fa6](dfe0fa6))
* **core:** Invalid NODES_INCLUDE should not crash the app
([#7038](#7038))
([04e3178](04e3178)),
closes [#6683](#6683)
* **core:** Setup websocket keep-live messages
([#6866](#6866))
([8bdb07d](8bdb07d)),
closes [#6757](#6757)
* **core:** Throw `NodeSSLError` only for nodes that allow ignoring SSL
issues ([#6928](#6928))
([a01c3fb](a01c3fb))
* **Date & Time Node:** Dont parse date if it's not set (null or
undefined) ([#7050](#7050))
([d72f79f](d72f79f))
* **editor:** Fix sending of Ask AI tracking events
([#7002](#7002))
([fb05afa](fb05afa))
* **Microsoft Excel 365 Node:** Support for more extensions in workbook
rlc ([#7020](#7020))
([d6e1cf2](d6e1cf2))
* **MongoDB Node:** Stringify response ObjectIDs
([#6990](#6990))
([9ca990b](9ca990b))
* **MongoDB Node:** Upgrade mongodb package to address CVE-2021-32050
([#7054](#7054))
([d3f6356](d3f6356))
* **Postgres Node:** Empty return data fix for Postgres and MySQL
([#7016](#7016))
([176ccd6](176ccd6))
* **Webhook Node:** Fix URL params for webhooks
([#6986](#6986))
([596b569](596b569))


### Features

* **core:** External Secrets storage for credentials
([#6477](#6477))
([ed927d3](ed927d3))
* **core:** Add MFA ([#4767](#4767))
([2b7ba6f](2b7ba6f))
* **core:** Add filtering, selection and pagination to users
([#6994](#6994))
([b716241](b716241))
* **editor:** Debug executions in the editor
([#6834](#6834))
([c833078](c833078))
* **RSS Read Node:** Add support for self signed certificates
([#7039](#7039))
([3b9f0fe](3b9f0fe))

Co-authored-by: netroy <[email protected]>
@janober
Copy link
Member

janober commented Aug 31, 2023

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netroy netroy netroy left review comments

@krynble krynble krynble approved these changes

@OlegIvaniv OlegIvaniv OlegIvaniv left review comments

@mutdmour mutdmour mutdmour left review comments

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@RicardoE105 @mutdmour @krynble @janober @netroy @OlegIvaniv