Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add message for readonly nodes. Improve foreign credentials handling #4759

Merged
merged 2 commits into from
Dec 6, 2022
Merged

feat: Add message for readonly nodes. Improve foreign credentials handling #4759

merged 2 commits into from
Dec 6, 2022

Conversation

alexgrozav
Copy link
Member

image

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Nov 29, 2022
freyamade
freyamade reviewed Nov 29, 2022
View reviewed changes
Copy link
Contributor

@freyamade freyamade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a look and while I'm not an FE dev, I think the PR looks good enough to merge to me at least! 👍

@CLAassistant
Copy link

CLAassistant commented Dec 2, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@alexgrozav alexgrozav added the Upcoming Release Will be part of the upcoming release label Dec 5, 2022
freyamade
freyamade suggested changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@freyamade freyamade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

freyamade
freyamade previously requested changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@freyamade freyamade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second attempt sorry!

freyamade
freyamade approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@freyamade freyamade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

attempt number three?

@alexgrozav alexgrozav merged commit eb112ff into master Dec 6, 2022
@alexgrozav alexgrozav deleted the n8n-5770-improve-experience-for-read-only-state branch December 6, 2022 10:15
MiloradFilipovic added a commit that referenced this pull request Dec 6, 2022
@MiloradFilipovic
Merge branch 'master' into feature/undo-redo
69313f1 
* master:
  fix: Handle error when workflow does not exist or is inaccessible (#4831)
  feat(editor): Schema view (#4615)
  fix: Enable source-maps on WorkflowRunnerProcess in `own` mode (#4832)
  ci: Fix linting on master (no-changelog) (#4830)
  feat: Add message for readonly nodes. Improve foreign credentials handling (#4759)
  feat(KoBoToolbox Node): Add support for Media file API (#4578)
  fix(Local File Trigger Node): Fix issue that causes a crash if the ignore field is empty (#4824) (#4825)
  refactor: Codex updates for XML and HtmlExtract Nodes (#4801)
  refactor: Reactivate workflow locking (#4770)

# Conflicts:
#	packages/editor-ui/src/Interface.ts
@janober
Copy link
Member

janober commented Dec 7, 2022

Got released with [email protected]

@janober janober removed the Upcoming Release Will be part of the upcoming release label Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freyamade freyamade freyamade approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexgrozav @CLAassistant @janober @freyamade @joaoramos