Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sao Paulo timezone should be GMT-3 #2647

Closed
m2scared opened this issue Jan 6, 2022 · 11 comments · Fixed by #6042 or CajuCLC/n8n-puppeteer-docker#3
Closed

Sao Paulo timezone should be GMT-3 #2647

m2scared opened this issue Jan 6, 2022 · 11 comments · Fixed by #6042 or CajuCLC/n8n-puppeteer-docker#3
Labels
in linear Issue or PR has been created in Linear for internal review

Comments

@m2scared
Copy link
Contributor

m2scared commented Jan 6, 2022

Describe the bug
Sao Paulo is configured as GMT-2 but it should be GMT-3.

See: https://en.wikipedia.org/wiki/List_of_tz_database_time_zones

Fix at: https://github.com/sanohin/google-timezones-json/pull/3/files

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Workflow'
  2. Click on 'Settings'
  3. Click on 'Timezone'
  4. Scroll down to 'Sao Paulo'
  5. See GMT-2

Expected behavior
See GMT-3.

Environment (please complete the following information):

  • OS: any
  • n8n Version 0.157.1
  • Node.js Version 14.15.0
  • Database system SQLite
  • Operation mode own

Additional context
N/A.

@luizeof
Copy link
Contributor

luizeof commented Jan 7, 2022

@harshil1712 we no longer have daylight save in brazil, now sao paulo is always -3:00 ;)

@Joffcom
Copy link
Member

Joffcom commented Jan 9, 2022

Hey,

Been chatting internally about this one, the module used has not been updated for a while so I don't know if they will accept the pull request so we may have to take another route.

I did find it interesting that the time has not changed since 2019 though.

@Joffcom
Copy link
Member

Joffcom commented Jan 18, 2022

Hey @m2scared & @luizeof,

Not forgotten about this one, We wanted to give the maintainer of the package enough time to accept the pull request before taking other routes to resolving this one. We have a couple of ideas so are just working out which one will be better to take long term.

@m2scared
Copy link
Contributor Author

Thanks @Joffcom.

@kimtiago
Copy link

Any news about this?

@Joffcom
Copy link
Member

Joffcom commented Apr 10, 2022

@kimtiago looks like the package we use has not accepted the fix yet so we will likely have to move on an alternative approach.

I will find see if I can find anything internally on this one.

@kimtiago
Copy link

kimtiago commented Apr 13, 2022

I need to tell you, other timezones from Brazil are wrong too.

Cuiaba GMT-03:00 should be GMT-04:00
Campo Grande GMT-03:00 should be GMT-04:00

Do I need to create another issue or we can use this issue?

https://greenwichmeantime.com/time-zone/south-america/brazil/cuiaba/
https://greenwichmeantime.com/time-zone/south-america/brazil/campo-grande/

@Joffcom
Copy link
Member

Joffcom commented Apr 13, 2022

Hey @kimtiago,

Here is fine, There are also Australian zones missing as well.

@netroy
Copy link
Member

netroy commented Jun 7, 2022

Would it make sense to switch to either of these 2 well-maintained libraries?

@Joffcom
Copy link
Member

Joffcom commented Jan 17, 2023

Just going to add that internally we are tracking this as N8N-3337

@Joffcom Joffcom added the in linear Issue or PR has been created in Linear for internal review label Jan 17, 2023
@Joffcom
Copy link
Member

Joffcom commented Apr 20, 2023

@m2scared they merged it 🙂

netroy added a commit that referenced this issue Apr 20, 2023
netroy added a commit that referenced this issue Apr 21, 2023
netroy added a commit that referenced this issue Apr 24, 2023
netroy added a commit that referenced this issue Apr 24, 2023
netroy added a commit that referenced this issue Apr 24, 2023
sunilrr pushed a commit to fl-g6/qp-n8n that referenced this issue Apr 24, 2023
netroy added a commit that referenced this issue Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in linear Issue or PR has been created in Linear for internal review
Projects
None yet
5 participants