feat(core): Filter executions by project ID in internal API #10976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
netroy
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
LGTM, but I have two concerns for the long run
- The queries in this repository are starting to become a bit too complicated and hard to maintain. We should look into refactoring these.
- We already support filtering by projectId in the public api because that endpoint has it's own implementation that does not use queries from this repository. We should try to consolidate these codes soon, before they diverge so far that we have to start worrying about maintaining two implementations to provide backward compatibility on the public API.
100% - I've brought up these two concerns on executions repository and Public API before, e.g. here. We only need the bandwidth. |
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
pay-1999-update-executions-api-filtering
|
| Run status |
|
| Run duration | 04m 20s |
| Commit |
|
| Committer | Iván Ovejero |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
2
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
432
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
|
Got released with |
ivov
added a commit
that referenced
this pull request
Nov 6, 2024
Follow-up to #10976 This was not caught there as the tests were for logic after middleware.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/n8n/issue/PAY-1999