Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure user id for early track events #10885

Merged
merged 4 commits into from
Sep 23, 2024
Merged

fix: Ensure user id for early track events #10885

merged 4 commits into from
Sep 23, 2024

Conversation

mutdmour
Copy link
Contributor

@mutdmour mutdmour commented Sep 19, 2024

Summary

  • fix bug where early track events don't have user id
  • ensure identify is set when user is fetched before those track events to set user id

Related Linear tickets, Github issues, and Community forum posts

Fixes ADO-2438

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Sep 19, 2024
@mutdmour mutdmour marked this pull request as ready for review September 23, 2024 10:38
Copy link
Contributor

@MiloradFilipovic MiloradFilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I left a comment with a question but might be unrelevant

@@ -146,6 +144,10 @@ export class Telemetry {
}
}

reset() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also a call to rudderStack.reset in identify action (here). Do we still need that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we still need that when initializing RS if user is not logged in.

@mutdmour mutdmour merged commit 23c09ea into master Sep 23, 2024
25 of 28 checks passed
@mutdmour mutdmour deleted the ado-2438 branch September 23, 2024 12:13
@github-actions github-actions bot mentioned this pull request Sep 25, 2024
@janober
Copy link
Member

janober commented Sep 25, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants