Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): Add truncate directive #10842

Merged
merged 4 commits into from
Sep 17, 2024

Conversation

cstuncsik
Copy link
Contributor

Summary

Introduce truncate Vue directive

Related Linear tickets, Github issues, and Community forum posts

PAY-1972

Review / Merge checklist

  • PR title and summary are descriptive.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Sep 17, 2024
Copy link
Contributor

@tomi tomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides missing documentation, looks good 👍

@cstuncsik cstuncsik requested a review from tomi September 17, 2024 10:13
Copy link
Contributor

@tomi tomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link

cypress bot commented Sep 17, 2024

n8n    Run #6908

Run Properties:  status check passed Passed #6908  •  git commit f5686cbd87: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 cstuncsik 🗃️ e2e/*
Project n8n
Branch Review pay-1972-add-truncate-vue-directive
Run status status check passed Passed #6908
Run duration 04m 46s
Commit git commit f5686cbd87: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 cstuncsik 🗃️ e2e/*
Committer Csaba Tuncsik
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 430
View all changes introduced in this branch ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@cstuncsik cstuncsik requested a review from tomi September 17, 2024 11:42
Copy link
Contributor

✅ All Cypress E2E specs passed

@cstuncsik cstuncsik merged commit 57836cc into master Sep 17, 2024
33 checks passed
@cstuncsik cstuncsik deleted the pay-1972-add-truncate-vue-directive branch September 17, 2024 12:00
MiloradFilipovic added a commit that referenced this pull request Sep 17, 2024
* master:
  ci: Setup biome and pre-commit hooks for formatting (no-changelog) (#10795)
  feat(editor): Add truncate directive (#10842)
  fix(editor): Allow custom git repo urls in source control settings (#10849)
  fix(Invoice Ninja Node): Fix lint error (no-changelog) (#10848)
  fix(editor): Minimap Show nodes outside viewport (#10843)
  fix(core): Prevent shutdown error in regular mode (#10844)
  feat(Invoice Ninja Node): Add actions for bank transactions (#10389)
  fix(editor): Address edge toolbar rendering glitches (#10839)
@github-actions github-actions bot mentioned this pull request Sep 18, 2024
@janober
Copy link
Member

janober commented Sep 18, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants