fix(API): Fix workflow project transfer #10651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the unit test to reproduce an issue that was detected.
A separate commit will be used to fix the problem.
The output below is from this test failure:
n8n:test: ● PUT /workflows/:id/transfer › should transfer workflow to project
n8n:test:
n8n:test: expect(received).toBe(expected) // Object.is equality
n8n:test:
n8n:test: Expected: "htfVcAUznnWmLzQE"
n8n:test: Received: "gLQLBvrhUglvs1DC"
n8n:test:
n8n:test: 1537 | const workflowsInProjectResponse = await authMemberAgent.get(`/workflows?projectId=${secondProject.id}`).send();
n8n:test: 1538 | expect(workflowsInProjectResponse.statusCode).toBe(200);
n8n:test: > 1539 | expect(workflowsInProjectResponse.body.data[0].id).toBe(workflow.id);
n8n:test: | ^
n8n:test: 1540 | });
n8n:test: 1541 |
n8n:test: 1542 | test('if no destination project, should reject', async () => {
n8n:test:
n8n:test: at Object.<anonymous> (test/integration/publicApi/workflows.test.ts:1539:54)
n8n:test:
…er workflow to project via public api Transfering a workflow to another project using the public API was failing because the code was dereferencing that wrong parameter name and getting undefined.
|
|
n8n-assistant
bot
added
community
|
Hey @benrobot, Thanks for the PR, We have created "GHC-199" as the internal reference to get this reviewed. One of us will be in touch if there are any changes needed, in most cases this is normally within a couple of weeks but it depends on the current workload of the team. |
ivov
previously approved these changes
Sep 3, 2024
benrobot
changed the title
|
@benrobot Thanks again for your contribution. Once the lint issues are fixed we can bring this in. Let us know if we can help or if you'd like for us to take over. |
ivov
approved these changes
Sep 27, 2024
MiloradFilipovic
added a commit
that referenced
this pull request
Sep 30, 2024
* master: feat(Iterable Node): Add support for EDC and USDC selection (#10908) test(Schedule Trigger Node): Add tests and extract trigger test helper (no-changelog) (#10625) fix(Todoist Node): Fix listSearch filter bug in Todoist Node (#10989) fix(AwsS3 Node): Fix search only using first input parameters (#10998) fix(editor): Fix bug causing node issues to not be assigned before first interaction (no-changelog) (#10980) fix(editor): Allow resources to move between personal and team projects (#10683) fix(Respond to Webhook Node): Node does not work with Wait node (#10992) fix(core): Upgrade @n8n/typeorm to address a rare mutex release issue (#10993) refactor(core): Separate execution `startedAt` from `createdAt` (#10810) refactor(core): Make all pubsub messages type-safe (#10990) feat(Question and Answer Chain Node): Customize question and answer system prompt (#10385) fix(editor): Fix performance issue in credentials list (#10988) fix(RSS Feed Trigger Node): Fix regression on missing timestamps (#10991) fix(editor): Fix workflow executions list page redirection (#10981) fix(editor): Fix filter execution by "Queued" (#10987) fix(API): Fix workflow project transfer (#10651)
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Transferring a workflow to a new project via the Public API was failing.
The unit test responsible for detecting this type of issue was only passing because there were no other workflows and projects in the database. After updating the test to match a more real-world scenario the test started to fail as shown in the screenshot below:
Related Linear tickets, Github issues, and Community forum posts
none
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)