-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Wait Node): Append n8n attribution option #10585
Merged
ShireenMissi
merged 3 commits into
master
from
node-1613-community-issue-wait-node-doesnt-allow-removing-attribution
Aug 30, 2024
Merged
fix(Wait Node): Append n8n attribution option #10585
ShireenMissi
merged 3 commits into
master
from
node-1613-community-issue-wait-node-doesnt-allow-removing-attribution
Aug 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-radency
added
node/improvement
New feature or request
n8n team
Authored by the n8n team
node/issue
Issue with a node
labels
Aug 28, 2024
netroy
reviewed
Aug 28, 2024
…community-issue-wait-node-doesnt-allow-removing-attribution
ShireenMissi
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
✅ All Cypress E2E specs passed |
n8n Run #6689
Run Properties:
|
Project |
n8n
|
Branch Review |
node-1613-community-issue-wait-node-doesnt-allow-removing-attribution
|
Run status |
Passed #6689
|
Run duration | 04m 47s |
Commit |
a0ff12c327: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 michael-radency 🗃️ e2e/*
|
Committer | Michael Kret |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
421
|
View all changes introduced in this branch ↗︎ |
ShireenMissi
deleted the
node-1613-community-issue-wait-node-doesnt-allow-removing-attribution
branch
August 30, 2024 13:28
MiloradFilipovic
added a commit
that referenced
this pull request
Sep 2, 2024
* master: fix(core): Flush responses for ai streaming endpoints (#10633) fix: Re-enable infra provisioning and teardown (no-changelog) (#10636) feat(core): Execution curation (#10342) fix(Webhook Node): Add tests for utils (no-changelog) (#10613) fix: Fixes to cloud benchmarks (no-changelog) (#10634) test: Add JS CodeNode benchmark scenario (#10632) refactor(editor): Migrate `MainSidebar.vue` to composition API (no-changelog) (#10538) build: Fix `cli` nodemon config (#10628) docs: Add 'benchmark' scope to PR Title Conventions documentation (#10624) ci: Fixes to benchmarks in cloud (#10626) test(editor): Increase test coverage for users settings page and modal (#10623) fix(Wait Node): Append n8n attribution option (#10585) refactor(editor): Migrate `NodeSettings.vue` to composition API (#10545) fix(editor): Add pinned data only to manual executions in execution view (#10605) ci: Omit benchmark scope commits from changelog (no-changelog) (#10618) fix: Disable errors obfuscation (no-changelog) (#10617) ci: Fix script name in gh workflow (#10619) ci: Fix nightly image not being pushed to ghcr (#10620)
Merged
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
n8n team
Authored by the n8n team
node/improvement
New feature or request
node/issue
Issue with a node
Released
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
adds Append n8n attribution option
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-1613/community-issue-wait-node-doesnt-allow-removing-attribution-for-form#comment-977416ed
#10515