Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Webflow Node): Update scopes to include forms #10554

Merged
merged 1 commit into from
Sep 9, 2024
Merged

fix(Webflow Node): Update scopes to include forms #10554

merged 1 commit into from
Sep 9, 2024

Conversation

oscarpedrero
Copy link
Contributor

@oscarpedrero oscarpedrero commented Aug 26, 2024 •
edited
Loading

Summary

Added the forms:read parameter to the scope, which was missing when legacy mode was unchecked. This caused the form submission functionality to stop working. Issue #10549

Related Linear tickets, Github issues, and Community forum posts

Issue #10549
Post https://community.n8n.io/t/webflow-integration-isn-t-working/48185/23

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@oscarpedrero
Update WebflowOAuth2Api.credentials.ts
54beedc 
Added the forms:read parameter to the scope, which was missing when legacy mode was unchecked. This caused the form submission functionality to stop working. Issue n8n-io#10549
@CLAassistant
Copy link

CLAassistant commented Aug 26, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@oscarpedrero oscarpedrero mentioned this pull request Aug 26, 2024
Closed
@n8n-assistant n8n-assistant bot added community Authored by a community member node/improvement New feature or request in linear Issue or PR has been created in Linear for internal review labels Aug 26, 2024
@Joffcom
Copy link
Member

Joffcom commented Aug 26, 2024

Hey @oscarpedrero,

Thanks for the PR, We have created "GHC-188" as the internal reference to get this reviewed.

One of us will be in touch if there are any changes needed, in most cases this is normally within a couple of weeks but it depends on the current workload of the team.

@Joffcom Joffcom changed the title Update scopes in WebflowOAuth2Api.credentials.ts for form submissions fix(Webflow Node): Update scopes to include forms Sep 9, 2024
Joffcom
Joffcom approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@Joffcom Joffcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me thanks for fixing this.

@Joffcom Joffcom merged commit d3861b3 into n8n-io:master Sep 9, 2024
14 of 19 checks passed
MiloradFilipovic added a commit that referenced this pull request Sep 10, 2024
@MiloradFilipovic
Merge branch 'master' into setup-and-auth-view-to-composition-api
65e6e74 
* master:
  feat(benchmark): New options for n8n benchmark (#10741)
  fix(Chat Trigger Node): Fix auth in "Embedded Chat" mode (#10734)
  fix(Webflow Node): Update scopes to include forms (#10554)
  test(editor): Add unit tests for `sanitizeHtml` (#10737)
  fix(editor): Fix xss issues in toast usages (#10733)
  fix(OpenAI Chat Model Node): Prevent filtering of fine-tuned models in model selector (#10662)
  feat: Filter parameter: Improve loose type validation for booleans (#10702)
  test: Add scaling n8n setup (multi-main) (#10644)
  refactor(editor): Migrate NodeWebhooks to Composition API (no-changelog) (#10710)
  fix(editor): Fix broken executions view (no-changelog) (#10714)
  fix(editor): Don't render pinned icon for disabled nodes (#10712)
@github-actions github-actions bot mentioned this pull request Sep 11, 2024
Merged
@Joffcom
Copy link
Member

Joffcom commented Sep 11, 2024

Got released with [email protected]

riascho pushed a commit that referenced this pull request Sep 23, 2024
@oscarpedrero @riascho
fix(Webflow Node): Update scopes to include forms (#10554)
3879ffb
@ferminmedina1
Copy link

Hey there! First of all, thanks for all the work on this update! I'm pretty new to this, so I might be missing something, but it seems like the functionality related to forms still isn't working properly. I followed the steps, but when I try to use the integration, it keeps failing. If anyone has any suggestions or if I'm doing something wrong, I'd really appreciate the help. Thanks in advance!

@riascho
Copy link
Contributor

riascho commented Oct 4, 2024

Hi @ferminmedina1, thanks for the feedback! Are you using it on cloud?
We are still due updating our OAuth2 credentials there (should be eod hopefully) and then you will just have to restart your n8n instance and create a new Webflow credential (with legacy disabled) - and that should work then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Joffcom Joffcom Joffcom approved these changes

Assignees
No one assigned
Labels
community Authored by a community member in linear Issue or PR has been created in Linear for internal review node/improvement New feature or request Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@oscarpedrero @CLAassistant @Joffcom @ferminmedina1 @riascho