fix(editor): Fix execution retry button #10275
Conversation
cstuncsik
added
the
release/backport
n8n-assistant
bot
added
n8n team
There was a problem hiding this comment.
Didn't we fix this like 4 months ago.
Can we please expand on tests, or create unit tests for isExecutionRetriable to ensure that this does not come back again in a few months?
Yes, I did, and I added unit tests, but unfortunately, I misunderstood how it should work, and it was unit tested correctly with the wrong behavior. This PR updates both the logic and unit tests accordingly. |
|
✅ All Cypress E2E specs passed |
|
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <[email protected]>
|
Got released with |
* master: refactor(core): Clean up event relays (no-changelog) (#10284) fix(editor): Fix execution retry button (#10275) feat(core): Show sub-node error on the logs pane. Open logs pane on sub-node error (#10248) refactor(core): Move instanceRole to InstanceSettings (no-changelog) (#10242) feat(core): Allow filtering executions and users by project in Public API (#10250) fix(core): Make execution and its data creation atomic (#10276) refactor(core): Mark schema env vars used by cloud hooks (no-changelog) (#10283) ci: Fix DB tests (no-changelog) (#10282) feat(core): Support create, delete, edit role for users in Public API (#10279) refactor(core): Decouple post workflow execute event from internal hooks (no-changelog) (#10280) feat(core): Allow transferring credentials in Public API (#10259) feat(core): Support create, read, update, delete projects in Public API (#10269) ci: Introduce lint rule `no-type-unsafe-event-emitter` (no-changelog) (#10254) fix(core): Surface enterprise trial error message (#10267) fix(editor): Enable moving resources only if team projects are available by the license (#10271) fix(core): Upgrade tournament to address some XSS vulnerabilities (#10277) # Conflicts: # packages/cli/src/Server.ts
Summary
Workflow execution retry button displaying logic is broken.
Related Linear tickets, Github issues, and Community forum posts
PAY-1776
Review / Merge checklist
release/backport