fix(core): Log crash causes to console when sentry is disabled (#6890)

n8n-io · Aug 17, 2023 · ff2d4ac · ff2d4ac
1 parent a4eb9b8
commit ff2d4ac
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/packages/cli/src/ErrorReporting.ts b/packages/cli/src/ErrorReporting.ts
@@ -7,15 +7,15 @@ let initialized = false;
 export const initErrorHandling = async () => {
 	if (initialized) return;
 
-	if (!config.getEnv('diagnostics.enabled')) {
+	const dsn = config.getEnv('diagnostics.config.sentry.dsn');
+	if (!config.getEnv('diagnostics.enabled') || !dsn) {
 		initialized = true;
 		return;
 	}
 
 	// Collect longer stacktraces
 	Error.stackTraceLimit = 50;
 
-	const dsn = config.getEnv('diagnostics.config.sentry.dsn');
 	const { N8N_VERSION: release, ENVIRONMENT: environment } = process.env;
 
 	const { init, captureException, addGlobalEventProcessor } = await import('@sentry/node');

diff --git a/packages/cli/src/config/schema.ts b/packages/cli/src/config/schema.ts
@@ -1087,8 +1087,7 @@ export const schema = {
 				dsn: {
 					doc: 'Data source name for error tracking on Sentry',
 					format: String,
-					default:
-						'https://[email protected]/4504016528408576',
+					default: '',
 					env: 'N8N_SENTRY_DSN',
 				},
 			},