Skip to content

Commit

Permalink
fix(core): Add executionData to expressions in pagination code (#10926)
Browse files Browse the repository at this point in the history
  • Loading branch information
elsmr authored Sep 23, 2024
1 parent 5c171c4 commit eac103e
Show file tree
Hide file tree
Showing 2 changed files with 1,911 additions and 1,964 deletions.
20 changes: 16 additions & 4 deletions packages/core/src/NodeExecuteFunctions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2995,6 +2995,8 @@ const getRequestHelperFunctions = (
workflow: Workflow,
node: INode,
additionalData: IWorkflowExecuteAdditionalData,
runExecutionData: IRunExecutionData | null = null,
connectionInputData: INodeExecutionData[] = [],
): RequestHelperFunctions => {
const getResolvedValue = (
parameterValue: NodeParameterValueType,
Expand All @@ -3004,8 +3006,6 @@ const getRequestHelperFunctions = (
additionalKeys?: IWorkflowDataProxyAdditionalKeys,
returnObjectAsString = false,
): NodeParameterValueType => {
const runExecutionData: IRunExecutionData | null = null;
const connectionInputData: INodeExecutionData[] = [];
const mode: WorkflowExecuteMode = 'internal';

if (
Expand Down Expand Up @@ -3874,7 +3874,13 @@ export function getExecuteFunctions(
helpers: {
createDeferredPromise,
copyInputItems,
...getRequestHelperFunctions(workflow, node, additionalData),
...getRequestHelperFunctions(
workflow,
node,
additionalData,
runExecutionData,
connectionInputData,
),
...getSSHTunnelFunctions(),
...getFileSystemHelperFunctions(node),
...getBinaryHelperFunctions(additionalData, workflow.id),
Expand Down Expand Up @@ -4031,7 +4037,13 @@ export function getExecuteSingleFunctions(
},
helpers: {
createDeferredPromise,
...getRequestHelperFunctions(workflow, node, additionalData),
...getRequestHelperFunctions(
workflow,
node,
additionalData,
runExecutionData,
connectionInputData,
),
...getBinaryHelperFunctions(additionalData, workflow.id),

assertBinaryData: (propertyName, inputIndex = 0) =>
Expand Down
Loading

0 comments on commit eac103e

Please sign in to comment.