Skip to content

Commit

Permalink
fix(Notion Node): Rename Notion API Key to Internal Integration Token (
Browse files Browse the repository at this point in the history
…#7176)

Github issue / Community forum post (link here to close automatically):
  • Loading branch information
elsmr authored and netroy committed Oct 4, 2023
1 parent 167124c commit e606ded
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion cypress/e2e/17-sharing.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ describe('Sharing', { disableAutoLogin: true }, () => {
credentialsPage.getters.emptyListCreateCredentialButton().click();
credentialsModal.getters.newCredentialTypeOption('Notion API').click();
credentialsModal.getters.newCredentialTypeButton().click();
credentialsModal.getters.connectionParameter('API Key').type('1234567890');
credentialsModal.getters.connectionParameter('Internal Integration Secret').type('1234567890');
credentialsModal.actions.setName('Credential C1');
credentialsModal.actions.save();
credentialsModal.actions.close();
Expand Down
14 changes: 7 additions & 7 deletions cypress/e2e/2-credentials.cy.ts
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
import {
NEW_NOTION_ACCOUNT_NAME,
NOTION_NODE_NAME,
PIPEDRIVE_NODE_NAME,
HTTP_REQUEST_NODE_NAME,
NEW_QUERY_AUTH_ACCOUNT_NAME,
GMAIL_NODE_NAME,
HTTP_REQUEST_NODE_NAME,
NEW_GOOGLE_ACCOUNT_NAME,
NEW_NOTION_ACCOUNT_NAME,
NEW_QUERY_AUTH_ACCOUNT_NAME,
NEW_TRELLO_ACCOUNT_NAME,
NOTION_NODE_NAME,
PIPEDRIVE_NODE_NAME,
SCHEDULE_TRIGGER_NODE_NAME,
TRELLO_NODE_NAME,
} from '../constants';
import { CredentialsPage, CredentialsModal, WorkflowPage, NDV } from '../pages';
import { CredentialsModal, CredentialsPage, NDV, WorkflowPage } from '../pages';
import { getVisibleSelect } from '../utils';

const credentialsPage = new CredentialsPage();
Expand All @@ -33,7 +33,7 @@ describe('Credentials', () => {
credentialsModal.getters.newCredentialTypeOption('Notion API').click();

credentialsModal.getters.newCredentialTypeButton().click();
credentialsModal.getters.connectionParameter('API Key').type('1234567890');
credentialsModal.getters.connectionParameter('Internal Integration Secret').type('1234567890');

credentialsModal.actions.setName('My awesome Notion account');
credentialsModal.actions.save();
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/credentials/NotionApi.credentials.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export class NotionApi implements ICredentialType {

properties: INodeProperties[] = [
{
displayName: 'API Key',
displayName: 'Internal Integration Secret',
name: 'apiKey',
type: 'string',
typeOptions: { password: true },
Expand Down

0 comments on commit e606ded

Please sign in to comment.