disable secure cookies in tests

n8n-io · Mar 5, 2024 · da3eef6 · da3eef6
1 parent 3d5977c
commit da3eef6
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/packages/cli/src/auth/auth.service.ts b/packages/cli/src/auth/auth.service.ts
@@ -4,7 +4,7 @@ import { createHash } from 'crypto';
 import { JsonWebTokenError, TokenExpiredError, type JwtPayload } from 'jsonwebtoken';
 
 import config from '@/config';
-import { AUTH_COOKIE_NAME, RESPONSE_ERROR_MESSAGES, Time } from '@/constants';
+import { AUTH_COOKIE_NAME, RESPONSE_ERROR_MESSAGES, Time, inTest } from '@/constants';
 import type { User } from '@db/entities/User';
 import { UserRepository } from '@db/repositories/user.repository';
 import { AuthError } from '@/errors/response-errors/auth.error';
@@ -79,7 +79,7 @@ export class AuthService {
 			maxAge: this.jwtExpiration * Time.seconds.toMilliseconds,
 			httpOnly: true,
 			sameSite: 'lax',
-			secure: true,
+			secure: !inTest,
 		});
 	}
 

diff --git a/packages/cli/test/unit/auth/auth.service.test.ts b/packages/cli/test/unit/auth/auth.service.test.ts
@@ -76,7 +76,7 @@ describe('AuthService', () => {
 				httpOnly: true,
 				maxAge: 604800000,
 				sameSite: 'lax',
-				secure: true,
+				secure: false,
 			});
 		});
 	});
@@ -164,7 +164,7 @@ describe('AuthService', () => {
 				httpOnly: true,
 				maxAge: 604800000,
 				sameSite: 'lax',
-				secure: true,
+				secure: false,
 			});
 		});
 

diff --git a/packages/cli/test/unit/controllers/me.controller.test.ts b/packages/cli/test/unit/controllers/me.controller.test.ts
@@ -70,7 +70,7 @@ describe('MeController', () => {
 					maxAge: expect.any(Number),
 					httpOnly: true,
 					sameSite: 'lax',
-					secure: true,
+					secure: false,
 				}),
 			);
 
@@ -188,7 +188,7 @@ describe('MeController', () => {
 					maxAge: expect.any(Number),
 					httpOnly: true,
 					sameSite: 'lax',
-					secure: true,
+					secure: false,
 				}),
 			);