fix(editor): Make inputs in the filter component expressions by defau…

…lt (#8784)
n8n-io · Mar 11, 2024 · c38043b · c38043b
1 parent 5226e00
commit c38043b
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 5 deletions.
diff --git a/cypress/e2e/30-if-node.cy.ts b/cypress/e2e/30-if-node.cy.ts
@@ -24,8 +24,16 @@ describe('If Node (filter component)', () => {
 
 		// Add
 		ndv.actions.addFilterCondition(FILTER_PARAM_NAME);
-		ndv.getters.filterConditionLeft(FILTER_PARAM_NAME, 0).find('input').type('first left');
-		ndv.getters.filterConditionLeft(FILTER_PARAM_NAME, 1).find('input').type('second left');
+		ndv.getters
+			.filterConditionLeft(FILTER_PARAM_NAME, 0)
+			.find('.cm-content')
+			.first()
+			.type('first left');
+		ndv.getters
+			.filterConditionLeft(FILTER_PARAM_NAME, 1)
+			.find('.cm-content')
+			.first()
+			.type('second left');
 		ndv.actions.addFilterCondition(FILTER_PARAM_NAME);
 		ndv.getters.filterConditions(FILTER_PARAM_NAME).should('have.length', 3);
 
@@ -34,8 +42,9 @@ describe('If Node (filter component)', () => {
 		ndv.getters.filterConditions(FILTER_PARAM_NAME).should('have.length', 2);
 		ndv.getters
 			.filterConditionLeft(FILTER_PARAM_NAME, 0)
-			.find('input')
-			.should('have.value', 'second left');
+			.find('.cm-content')
+			.first()
+			.should('have.text', 'second left');
 		ndv.actions.removeFilterCondition(FILTER_PARAM_NAME, 1);
 		ndv.getters.filterConditions(FILTER_PARAM_NAME).should('have.length', 1);
 	});

diff --git a/packages/editor-ui/src/components/FilterConditions/FilterConditions.vue b/packages/editor-ui/src/components/FilterConditions/FilterConditions.vue
@@ -43,7 +43,7 @@ const ndvStore = useNDVStore();
 const { debounce } = useDebounce();
 
 function createCondition(): FilterConditionValue {
-	return { id: uuid(), leftValue: '', rightValue: '', operator: DEFAULT_OPERATOR_VALUE };
+	return { id: uuid(), leftValue: '=', rightValue: '=', operator: DEFAULT_OPERATOR_VALUE };
 }
 
 const allowedCombinators = computed<FilterTypeCombinator[]>(

diff --git a/packages/editor-ui/src/components/FilterConditions/__tests__/FilterConditions.test.ts b/packages/editor-ui/src/components/FilterConditions/__tests__/FilterConditions.test.ts
@@ -43,7 +43,14 @@ describe('FilterConditions.vue', () => {
 		expect(getByTestId('filter-conditions')).toBeInTheDocument();
 		expect(await findAllByTestId('filter-condition')).toHaveLength(1);
 		expect(getByTestId('filter-condition-left')).toBeInTheDocument();
+		expect(
+			within(getByTestId('filter-condition-left')).getByTestId('inline-expression-editor-input'),
+		).toBeInTheDocument();
 		expect(getByTestId('filter-operator-select')).toBeInTheDocument();
+		expect(getByTestId('filter-condition-right')).toBeInTheDocument();
+		expect(
+			within(getByTestId('filter-condition-right')).getByTestId('inline-expression-editor-input'),
+		).toBeInTheDocument();
 
 		// Only visible when multiple conditions
 		expect(queryByTestId('filter-combinator-select')).not.toBeInTheDocument();