Skip to content

Commit

Permalink
⚡ Minor i18n fixes (#2585)
Browse files Browse the repository at this point in the history
* ⚡ Make subcategory render keys consistent

* ⚡ Add missing or key

* ⚡ Fix default text for multiple value button

* ⚡ Simplify subcategory extraction
  • Loading branch information
ivov authored and ahsanv committed Dec 29, 2021
1 parent aecbc1b commit b3f2986
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 12 deletions.
4 changes: 2 additions & 2 deletions packages/editor-ui/src/components/MultipleParameter.vue
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@ export default mixins(genericHelpers)
computed: {
addButtonText (): string {
if (
!this.parameter.typeOptions &&
!this.parameter.typeOptions.multipleValueButtonText
!this.parameter.typeOptions ||
(this.parameter.typeOptions && !this.parameter.typeOptions.multipleValueButtonText)
) {
return this.$locale.baseText('multipleParameter.addItem');
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
</div>
<div class="action">
{{ $locale.baseText('nodeCreator.noResults.dontWorryYouCanProbablyDoItWithThe') }}
<a @click="selectHttpRequest">{{ $locale.baseText('nodeCreator.noResults.httpRequest') }}</a> or
<a @click="selectHttpRequest">{{ $locale.baseText('nodeCreator.noResults.httpRequest') }}</a> {{ $locale.baseText('nodeCreator.noResults.or') }}
<a @click="selectWebhook">{{ $locale.baseText('nodeCreator.noResults.webhook') }}</a> {{ $locale.baseText('nodeCreator.noResults.node') }}
</div>
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
{{ $locale.baseText(`nodeCreator.subcategoryNames.${subcategoryName}`) }}
</div>
<div v-if="item.properties.description" :class="$style.description">
{{ $locale.baseText(`nodeCreator.subcategoryDescriptions.${subcategoryDescription}`) }}
{{ $locale.baseText(`nodeCreator.subcategoryDescriptions.${subcategoryName}`) }}
</div>
</div>
<div :class="$style.action">
Expand All @@ -24,10 +24,6 @@ export default Vue.extend({
subcategoryName() {
return camelcase(this.item.properties.subcategory);
},
subcategoryDescription() {
const firstWord = this.item.properties.description.split(' ').shift() || '';
return firstWord.toLowerCase().replace(/,/g, '');
},
},
});
</script>
Expand Down
9 changes: 5 additions & 4 deletions packages/editor-ui/src/plugins/i18n/locales/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -413,6 +413,7 @@
"dontWorryYouCanProbablyDoItWithThe": "Don’t worry, you can probably do it with the",
"httpRequest": "HTTP Request",
"node": "node",
"or": "or",
"requestTheNode": "Request the node",
"wantUsToMakeItFaster": "Want us to make it faster?",
"weDidntMakeThatYet": "We didn't make that... yet",
Expand All @@ -422,10 +423,10 @@
"searchNodes": "Search nodes..."
},
"subcategoryDescriptions": {
"branches": "Branches, core triggers, merge data",
"http": "HTTP Requests (API calls), date and time, scrape HTML",
"manipulate": "Manipulate data fields, run code",
"work": "Work with CSV, XML, text, images etc."
"dataTransformation": "Manipulate data fields, run code",
"files": "Work with CSV, XML, text, images etc.",
"flow": "Branches, core triggers, merge data",
"helpers": "HTTP Requests (API calls), date and time, scrape HTML"
},
"subcategoryNames": {
"dataTransformation": "Data Transformation",
Expand Down

0 comments on commit b3f2986

Please sign in to comment.