Skip to content

Commit

Permalink
fix: Task Runner Auth CI fail with busy event loop (no-changelog) (#1…
Browse files Browse the repository at this point in the history
  • Loading branch information
valya authored Oct 2, 2024
1 parent a8d1a1e commit ae37035
Show file tree
Hide file tree
Showing 2 changed files with 36 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { sleep } from 'n8n-workflow';

import config from '@/config';
import { CacheService } from '@/services/cache/cache.service';
import { retryUntil } from '@test-integration/retry-until';

import { mockInstance } from '../../../../test/shared/mocking';
import { TaskRunnerAuthService } from '../task-runner-auth.service';
Expand Down Expand Up @@ -86,7 +87,9 @@ describe('TaskRunnerAuthService', () => {
// Act
await sleep(TTL + 1);

expect(await authService.tryConsumeGrantToken(grantToken)).toBe(false);
await retryUntil(async () =>
expect(await authService.tryConsumeGrantToken(grantToken)).toBe(false),
);
});
});
});
32 changes: 32 additions & 0 deletions packages/cli/test/integration/shared/retry-until.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
/**
* Retries the given assertion until it passes or the timeout is reached
*
* @example
* await retryUntil(
* () => expect(service.someState).toBe(true)
* );
*/
export const retryUntil = async (
assertion: () => Promise<void> | void,
{ interval = 20, timeout = 1000 } = {},
) => {
return await new Promise((resolve, reject) => {
const startTime = Date.now();

const tryAgain = () => {
setTimeout(async () => {
try {
resolve(await assertion());
} catch (error) {
if (Date.now() - startTime > timeout) {
reject(error);
} else {
tryAgain();
}
}
}, interval);
};

tryAgain();
});
};

0 comments on commit ae37035

Please sign in to comment.