fix(editor): Don't render pinned icon for disabled nodes (#10712)

n8n-io · Sep 6, 2024 · 879b837 · 879b837
1 parent 43713dc
commit 879b837
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/...-ui/src/components/canvas/elements/nodes/render-types/parts/CanvasNodeStatusIcons.spec.ts b/...-ui/src/components/canvas/elements/nodes/render-types/parts/CanvasNodeStatusIcons.spec.ts
@@ -18,6 +18,18 @@ describe('CanvasNodeStatusIcons', () => {
 		expect(getByTestId('canvas-node-status-pinned')).toBeInTheDocument();
 	});
 
+	it('should not render pinned icon when disabled', () => {
+		const { queryByTestId } = renderComponent({
+			global: {
+				provide: createCanvasNodeProvide({
+					data: { disabled: true, pinnedData: { count: 5, visible: true } },
+				}),
+			},
+		});
+
+		expect(queryByTestId('canvas-node-status-pinned')).not.toBeInTheDocument();
+	});
+
 	it('should render correctly for a running node', () => {
 		const { getByTestId } = renderComponent({
 			global: {

diff --git a/...itor-ui/src/components/canvas/elements/nodes/render-types/parts/CanvasNodeStatusIcons.vue b/...itor-ui/src/components/canvas/elements/nodes/render-types/parts/CanvasNodeStatusIcons.vue
@@ -15,6 +15,7 @@ const {
 	executionRunning,
 	hasRunData,
 	runDataIterations,
+	isDisabled,
 } = useCanvasNode();
 
 const hideNodeIssues = computed(() => false); // @TODO Implement this
@@ -45,7 +46,7 @@ const hideNodeIssues = computed(() => false); // @TODO Implement this
 		</N8nTooltip>
 	</div>
 	<div
-		v-else-if="hasPinnedData && !nodeHelpers.isProductionExecutionPreview.value"
+		v-else-if="hasPinnedData && !nodeHelpers.isProductionExecutionPreview.value && !isDisabled"
 		data-test-id="canvas-node-status-pinned"
 		:class="[$style.status, $style.pinnedData]"
 	>